fix: presigned url 에만 https 프로토콜 적용되도록 수정 #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choi-JJunho
commented
Mar 3, 2024
| uploadFileFullPath.unixValue(), new Date()); | ||
|
|
||
| UploadFileLocation uploadFileLocation = UploadFileLocation.of(domainUrlPrefix, uploadFileFullPath); | ||
| UploadFileLocation uploadFileLocation = UploadFileLocation.of(HTTPS_PROTOCOL + domainUrlPrefix, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안드로이드의 presignedUrl의 경로에 대응하기위해
https://프로토콜 path를 추가해줌이로 인해 기존에 사용하던 file upload에 대해서도
https://가 추가됨프론트엔드에서 해당 파일 업로드 API가 얼마나 남았는지 확인하기 어렵다고 하여 기존에 사용하던 방식에 대한 file upload API는 기존 방식으로 유지하는 방향으로 fix한다.
