Skip to content

Attempts account removal from broker first #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Attempts account removal from broker first #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion msal/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,12 +1123,13 @@ def _get_authority_aliases(self, instance):

def remove_account(self, account):
"""Sign me out and forget me from token cache"""
self._forget_me(account)
if self._enable_broker:
from .broker import _signout_silently
error = _signout_silently(self.client_id, account["local_account_id"])
if error:
logger.debug("_signout_silently() returns error: %s", error)
# Broker sign-out has been attempted, even if the _forget_me() below throws.
self._forget_me(account)

def _sign_out(self, home_account):
# Remove all relevant RTs and ATs from token cache
Expand Down