Skip to content

Chanbge acquire_token_interactive to lazy import webbrowser #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2020
Merged

Chanbge acquire_token_interactive to lazy import webbrowser #288

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2021382
Lazy import webbrowser to accommondate OpenWrt distro
rayluo Dec 14, 2020
17af762
Merge branch 'obtain-token-by-browser' into dev
rayluo Dec 14, 2020
0ccb44f
Merge remote-tracking branch 'oauth2cli/dev' into acquire-token-inter…
rayluo Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion msal/oauth2cli/authcode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
It optionally opens a browser window to guide a human user to manually login.
After obtaining an auth code, the web server will automatically shut down.
"""
import webbrowser
import logging
import socket
from string import Template
Expand Down Expand Up @@ -35,6 +34,7 @@ def obtain_auth_code(listen_port, auth_uri=None): # Historically only used in t


def _browse(auth_uri):
import webbrowser # Lazy import. Some distro may not have this.
controller = webbrowser.get() # Get a default controller
# Some Linux Distro does not setup default browser properly,
# so we try to explicitly use some popular browser, if we found any.
Expand Down