Skip to content

Do not filter mrrt by scope #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2020
Merged

Do not filter mrrt by scope #236

merged 2 commits into from
Jul 25, 2020

Conversation

@rayluo
Copy link
Contributor

@rayluo rayluo commented Jul 25, 2020

Found an issue introduced in #225. This PR fixes that, and will close #235

@rayluo rayluo requested a review from abhidnya13 July 25, 2020 00:11
abhidnya13
abhidnya13 approved these changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@abhidnya13 abhidnya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rayluo rayluo merged commit 5d862fa into dev Jul 25, 2020
@rayluo rayluo deleted the do-not-filter-mrrt-by-scope branch July 25, 2020 00:50
@rayluo rayluo mentioned this pull request Jul 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abhidnya13 abhidnya13 abhidnya13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MSAL python 1.4.2 is no longer able to read from other MSAL caches

3 participants

@rayluo @abhidnya13