Skip to content

Conversation

@abhidnya13
Copy link
Contributor

@abhidnya13 abhidnya13 commented Apr 13, 2020

Allows user to pass in domain hint when generating authorization URL


UPDATED (by Ray):
This PR will fix #158. (This line will trigger an automatic close of that issue. This is probably fine, because we will cut a new release shortly after this merge.)

@abhidnya13 abhidnya13 requested a review from rayluo April 13, 2020 22:28
Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature implementation is clean! Added a question for the docs.

@abhidnya13 abhidnya13 requested a review from rayluo April 14, 2020 19:48
Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Squash and merge!

@abhidnya13 abhidnya13 merged commit 61785a7 into dev Apr 14, 2020
@abhidnya13 abhidnya13 deleted the allow_domain_hint branch April 14, 2020 21:35
@rayluo rayluo mentioned this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to properly pass domain_hint?

3 participants