Skip to content

Adding api to enable additional caching parameters #4919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 13, 2024
Merged

Adding api to enable additional caching parameters #4919

merged 10 commits into from
Sep 13, 2024

Conversation

trwalke
Copy link
Member

@trwalke trwalke commented Sep 6, 2024 •
edited
Loading

Fixes #
#4922

Changes proposed in this request
Adding WithAdditionalCacheParameters api

Testing
Unit

Performance impact

Documentation

  • All relevant documentation is updated.

@trwalke trwalke requested a review from a team as a code owner September 6, 2024 08:46
bgavrilMS
bgavrilMS requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a work item and add a bit of spec. @rayluo and @localden can approve this. The spec should define acceptance tests.

Insufficient testing. Not asserting on AuthenticationResult.AdditionalResponseParameters.

@trwalke
Copy link
Member Author

trwalke commented Sep 10, 2024

added a new work item.
#4922

@trwalke trwalke requested review from bgavrilMS and rayluo September 10, 2024 04:48
@bgavrilMS bgavrilMS linked an issue Sep 11, 2024 that may be closed by this pull request
Add an api which will enable developers to cache additional values in the token response in the Access token #4922
Closed
bgavrilMS
bgavrilMS reviewed Sep 11, 2024
View reviewed changes
gladjohn
gladjohn approved these changes Sep 12, 2024
View reviewed changes
@gladjohn
Copy link
Contributor

looks good, just a few comments. In addition, can you also check to,

  • Ensure all additional parameters from the response are available in AdditionalResponseParameters if WithAdditionalCacheParameters is not used, hopefully there is an existing test, if not adding this will cover an additional check
  • a test to acquire a new token without WithAdditionalCacheParameters, to check what happens to cached AdditionalResponseParameters
  • Can we add any tests to verify the new API is only on CCA and not on PCA/MIA?

@trwalke trwalke merged commit b5177a4 into main Sep 13, 2024
6 checks passed
@trwalke trwalke deleted the trwalke/AdditionalCacheParams branch September 13, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@gladjohn gladjohn gladjohn approved these changes

@rayluo rayluo Awaiting requested review from rayluo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add an api which will enable developers to cache additional values in the token response in the Access token

3 participants

@trwalke @gladjohn @bgavrilMS