-
Notifications
You must be signed in to change notification settings - Fork 42
feat: migrate to biome #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
konrad-jamrozik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afonsojramos can you clarify why you are interested in this repository at all? What is your use case?
|
@afonsojramos sorry, but our team has standardized on |
|
No worries, standards supersede all! Might still be something to consider even if just for the formatting perf vs prettier though!
Was investigating all of the openapi diffing tools out there and enjoyed seeing some activity on this one! In the end I found one that better fits our needs, but still found it very useful! Keep up the good job! |
|
@afonsojramos thank you! Can you share the other diffing tools you looked at and which one you chose? |
|
Yeah, sure! Seems like the ones that are being most used at the moment are:
Key features that we were looking for, but that were not present in all are:
As such, and due to the specific needs that we had, we ended up going with @udamir's https://github.com/udamir/api-smart-diff. It is built in a beautifully scalable way, full TS and in a very maintainable state. So, if the star wasn't enough, thanks @udamir for that project! Hopefully I'll get to contribute to it in the future 🚀 |
Fixes #332 by migrating to biome (which also allows for the replacement of prettier).
I was working on this prior to #335, so sorry @konrad-jamrozik for opening this after your PR, but I believe that moving to biome is more beneficial than moving to eslint. Granted, biome is not as battle tested, but it serves the purpose this project needs way better than eslint in my opinion. The performance benefits are just a plus.