-
Notifications
You must be signed in to change notification settings - Fork 289
Added aspire sample #2977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added aspire sample #2977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a sample demonstrating how to use Data API Builder (DAB) in .NET Aspire. The sample includes a Star Trek database schema with actors, characters, series, and species data, along with the necessary configuration files to run DAB within an Aspire orchestration environment.
Key changes:
- Aspire orchestration setup with SQL Server, Data API Builder, SQL Commander, and MCP Inspector
- Star Trek database schema with comprehensive seed data covering multiple series
- DAB configuration with entities, relationships, views, and stored procedures
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/aspire/readme.md | Documentation explaining prerequisites, resources, and data structures |
| samples/aspire/global.json | .NET SDK version configuration |
| samples/aspire/database.sql | SQL schema and seed data for Star Trek database |
| samples/aspire/dab-config.json | DAB configuration with entities and relationships |
| samples/aspire/dab-config.cmd | CLI commands to generate DAB configuration |
| samples/aspire/apphost.cs | Aspire orchestration configuration |
| samples/aspire/.gitignore | Git ignore configuration |
| samples/aspire/.aspire/settings.json | Aspire settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
We really need to add this to our tests in order to avoid requiring the full suite of integration tests when /samples is updated. In fact, there are many paths in this repo that should be set up to allow pull requests to skip integration tests. Please consider. on:
pull_request:
paths-ignore:
- 'samples/**' |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
aaronburtle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just a couple nits.
|
@Aniruddh25 I've opened a new pull request, #2990, to work on those changes. Once the pull request is ready, I'll request review from you. |
Addresses feedback on PR #2977 to add the standard Microsoft copyright header to the Aspire sample's C# file. ## Changes - Added copyright notice to `samples/aspire/apphost.cs`: ```csharp // Copyright (c) Microsoft Corporation. // Licensed under the MIT License. ``` <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/Azure/data-api-builder/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Aniruddh25 <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
…tes) (#2988) ## Why make this change? Closes #2977. Running full integration test suites on PRs that only modify samples, documentation, or configuration files wastes CI resources and slows down contribution velocity. ## What is this change? Added `pr:` trigger sections with path exclusions to all 7 Azure Pipeline definitions in `.pipelines/`: **Excluded paths:** - `samples/**` - Sample configurations and code - `docs/**` - Documentation - `*.md` - Markdown files (README, CONTRIBUTING, etc.) - `schemas/**` - JSON schema definitions - `templates/**` - Project templates **Modified pipelines:** - `azure-pipelines.yml` - Static analysis - `cosmos-pipelines.yml` - CosmosDB integration tests - `dwsql-pipelines.yml` - Data Warehouse SQL tests - `mssql-pipelines.yml` - SQL Server tests - `mysql-pipelines.yml` - MySQL tests - `pg-pipelines.yml` - PostgreSQL tests - `unittest-pipelines.yml` - Unit test suite PRs touching only excluded paths will skip pipeline execution. PRs with mixed changes (code + excluded paths) still run all validations. ## How was this tested? - [x] YAML syntax validation - [ ] Integration Tests - N/A (configuration change) - [ ] Unit Tests - N/A (configuration change) ## Sample Request(s) N/A - Pipeline configuration change only. Validation occurs automatically on PR creation. <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Skip Pull Request validation for certain paths</issue_title> > <issue_description>We really need to add this to our tests in order to avoid requiring the full suite of integration tests when /samples is updated. In fact, there are many paths in this repo that should be set up to allow pull requests to skip integration tests. Please consider. > > ```yaml > on: > pull_request: > paths-ignore: > - 'samples/**' > ``` > > _Originally posted by @JerryNixon in #2977 (comment) > </issue_description> > > <agent_instructions>Modify the yml files in the .pipelines folder which do Pull Request validation to skip paths like samples. This will help checkin PRs on those paths quickly.</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> - Fixes #2987 <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Aniruddh25 <[email protected]>
Pull request was closed
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
aaronburtle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving to merge
This is a simple sample that demonstrates how to use DAB in Aspire.
I will add it to our docs/quick-starts when this is merged.
Please note there is no /src code change, just /samples.