-
Notifications
You must be signed in to change notification settings - Fork 289
Usr/sogh/mcpconfigentities.v3 #2976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
souvikghosh04
wants to merge
24
commits into
main
Choose a base branch
from
Usr/sogh/mcpconfigentities.v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Usr/sogh/dyn-tool-reg
… Usr/sogh/dyn-tool-reg
… Usr/sogh/dyn-tool-reg
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
bd45309 to
a7a5921
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
- Used config-generator.ps1 to regenerate config from scratch - Properties now in correct order: rest graphql mcp permissions - Removed deprecated 'dml-tools' setting from mcp section - This matches the output from the latest DAB CLI and should fix snapshot test failures
- Regenerated dab-config files for: MsSql, MySql, PostgreSql, CosmosDB, DwSql - All configs now have consistent property order: rest graphql mcp permissions - Removed deprecated settings where applicable - Ensures pipeline snapshot tests use configs generated by latest DAB CLI
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Problem: The DAB CLI ignores --graphql.operation parameter when adding/updating stored procedures, defaulting them to 'mutation' instead of 'query'. This breaks tests expecting 'executeGetPublisher' query field names. Solution: 1. Added --graphql.operation query to GetBooks add/update commands 2. Added --graphql.operation query to GetPublisher update command 3. Added post-processing in config-generator.ps1 to manually fix operations for GetBooks and GetPublisher after generation This ensures the pipeline generates configs with correct GraphQL operations, fixing the 5 failing MsSql stored procedure tests in CI/CD. Updated MsSql config and snapshot to match pipeline output.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
- Add --graphql.operation query to GetBooks add command - Fix GetBooks and GetPublisher update commands to use lowercase query - Extend post-processing script to also handle DwSql configs - Regenerate dab-config.DwSql.json with correct query operations
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
b928be7 to
bf781c6
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
656ad20 to
bd129d9
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
…ed to output directory This fixes Linux test failures where the post-processed DwSql config with correct stored procedure operations (query vs mutation) was not being copied to the test output directory.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
#syntax. e.g. Closes #XXWhat is this change?
How was this tested?
Sample Request(s)