Skip to content

Conversation

@RubenCerna2079
Copy link
Contributor

Why make this change?

  • Refine Service.Tests changes for MCP #2874
    There was a test that needed to be fixed in order to comply with the creation of the new MCP endpoint. The test already existed and covered the scenarios for REST and GraphQL endpoints. The reason this test needed to be fixed separately is that it was failing when it was changed to comply with the MCP endpoint.

What is this change?

This change fixes the test that was failing, the reason it was failing is that the MCP server was not able to start in time before the test tried to access the MCP endpoint. In order to fix it we added a delay so the server is available before the test tries to access the endpoint.

How was this tested?

  • Integration Tests
  • Unit Tests

@RubenCerna2079 RubenCerna2079 added this to the Oct 2025 milestone Oct 27, 2025
@RubenCerna2079 RubenCerna2079 self-assigned this Oct 27, 2025
Copilot AI review requested due to automatic review settings October 27, 2025 19:44
@RubenCerna2079 RubenCerna2079 changed the title Dev/rubencerna/mcp fix tests Fix missing MCP test Oct 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a failing test for MCP (Model Context Protocol) endpoint support. The test was extended to cover MCP endpoints alongside existing REST and GraphQL endpoint tests, but failed due to the MCP server not being ready in time.

Key changes:

  • Extended test parameters to include MCP endpoint testing alongside REST and GraphQL
  • Added a 2-second delay before MCP endpoint testing to allow server initialization
  • Created a helper method GetMcpResponsePostConfigHydration with retry logic similar to existing GraphQL helper

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RubenCerna2079
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@RubenCerna2079
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@RubenCerna2079
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@RubenCerna2079
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@RubenCerna2079
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@RubenCerna2079
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@RubenCerna2079
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for retry logic

@github-project-automation github-project-automation bot moved this from Todo to Review In Progress in Data API builder Oct 30, 2025
Copy link
Contributor

@souvikghosh04 souvikghosh04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know once the comments are addressed.

@RubenCerna2079
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@RubenCerna2079
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@RubenCerna2079
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review In Progress

Development

Successfully merging this pull request may close these issues.

4 participants