Adding 'Configure' Options to CLI for Azure Log Analytics #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenCerna2079
requested review from
Alekhya-Polavarapu,
Aniruddh25,
aaronburtle,
anushakolan,
neeraj-sharma2592,
ravishetye,
rusamant,
sourabh1007,
souvikghosh04 and
vadeveka
as code owners
Co-authored-by: RubenCerna2079 <[email protected]>
…erProvided flags Co-authored-by: aaronburtle <[email protected]>
…ided flags Co-authored-by: aaronburtle <[email protected]>
Aniruddh25
reviewed
Jul 22, 2025
Aniruddh25
reviewed
Jul 22, 2025
Aniruddh25
reviewed
Jul 22, 2025
Aniruddh25
requested changes
Jul 22, 2025
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Confirm nullability of azureLogAnalyticsOptions
github-project-automation
bot
moved this from Todo
to Review In Progress
in Data API builder
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Jul 23, 2025
Aniruddh25
approved these changes
Jul 23, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
souvikghosh04
approved these changes
Jul 29, 2025
Contributor
souvikghosh04
left a comment
souvikghosh04
left a comment
There was a problem hiding this comment.
LGTM. Approved with minor suggestions.
Contributor
Author
|
/azp run |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring Azure Log Analytics properties through the CLI's configure command, allowing users to set telemetry options without manually editing config files. The change includes validation improvements and ensures proper serialization of Azure Log Analytics configuration.
- Adds six new CLI options for Azure Log Analytics configuration (enabled, log-type, flush-interval-seconds, workspace-id, dcr-immutable-id, dce-endpoint)
- Implements validation logic to ensure Azure Log Analytics is properly configured with required auth options
- Updates JSON serialization to only include auth properties when user-provided values exist
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ConfigureOptions.cs | Adds new CLI option properties for Azure Log Analytics configuration |
| ConfigGenerator.cs | Implements configuration update logic and validation for Azure Log Analytics options |
| AzureLogAnalyticsOptionsConverterFactory.cs | Updates serialization logic to conditionally include auth properties |
| AzureLogAnalyticsAuthOptionsConverter.cs | Removes extraneous whitespace |
| ConfigureOptionsTests.cs | Adds unit test for Azure Log Analytics configuration functionality |
| ValidateConfigTests.cs | Adds validation test to ensure Azure Log Analytics fails without required auth options |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
RubenCerna2079
deleted the
dev/rubencerna/add-configure-cli-log-analytics
branch
github-project-automation
bot
moved this from Review In Progress
to Done
in Data API builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
This change closes issue #2777
What is this change?
This change extends the functionality of the
configureCLI command by introducing support for Azure Log Analytics properties. With this enhancement, users can now configure the Azure Log Analytics properties inside of their config file without the need to directly edit it.This change also ensures that the validation of Azure Log Analytics works as intended.
How was this tested?
Sample Request(s)
CLI Updates
Add support to dab configure:
dab configure --runtime.telemetry.azure-log-analytics.enabled
dab configure --runtime.telemetry.azure-log-analytics.auth.workspace-id
dab configure --runtime.telemetry.azure-log-analytics.auth.dcr-immutable-id
dab configure --runtime.telemetry.azure-log-analytics.auth.dce-endpoint
dab configure --runtime.telemetry.azure-log-analytics.log-type
dab configure --runtime.telemetry.azure-log-analytics.flush-interval-seconds