Change TypeName in DatabaseObject Serialization to exclude unwanted parts #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusamant
requested review from
Aniruddh25,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
neeraj-sharma2592,
ravishetye,
rohkhann,
seantleonard,
severussundar,
sourabh1007 and
tarazou9
as code owners
|
/azp run |
1 similar comment
|
/azp run |
vadeveka
approved these changes
Apr 6, 2024
abhishekkumams
approved these changes
Apr 8, 2024
rohkhann
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Change TypeName in DatabaseObjectConverter during DatabaseObject Serialization to exclude the unwanted parts.
Currently TypeName field added during DatabaseObject serialization is set to Type.AssemblyQualifiedName, which looks like : "Azure.DataApiBuilder.Config.DatabasePrimitives.DatabaseTable, Azure.DataApiBuilder.Config, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null"
1.0.0.0 was the default value set, hence when the version changes, deserialization will fail if the initial serialization had version as 1.0.0.0.
Updating this TypeName to only include the necessary parts : "Azure.DataApiBuilder.Config.DatabasePrimitives.DatabaseTable, Azure.DataApiBuilder.Config"
Tested again by using Type.FullName which is "Azure.DataApiBuilder.Config.DatabasePrimitives.DatabaseTable", but serialization fails saying DatabaseTable not found.
Why make this change?
Due to recent changes to update the version number based of release, deserialization on graphql workload failed, it is looking for version 1.0.0.0 which doesnot exists. Hence removing the dependency on version number.
How was this tested?