Cache Enablement check changes #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantleonard
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
severussundar and
tarazou9
as code owners
Aniruddh25
approved these changes
Feb 5, 2024
seantleonard
force-pushed
the
dev/sean/cache_skipWhenReadDbPolicyResolved
branch
2 times, most recently
from
6f0f7fb to
437ced8
Compare
…or request. Currently cache is used when db policy is resolved
…e config is enabled before using cache
…operation for role context
seantleonard
force-pushed
the
dev/sean/cache_skipWhenReadDbPolicyResolved
branch
from
437ced8 to
1a16ae6
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
seantleonard
added a commit
that referenced
this pull request
Feb 12, 2024
## Why make this change? - Ensure cache is used when enabled and add additional checks to make this flow as expected. ## What is this change? - Change cache check to ensure dbpolicies are NOT resolved for request in order to use cache - Add check to ensure entity cache is enabled. ## How was this tested? - TBD
seantleonard
added a commit
that referenced
this pull request
Feb 13, 2024
…#2033) Cherry picks #2011 and #2012 to main # 2012 ## Why make this change? - Ensure cache is used when enabled and add additional checks to make this flow as expected. ## What is this change? - Change cache check to ensure dbpolicies are NOT resolved for request in order to use cache - Add check to ensure entity cache is enabled. # 2011 ## Why this change? This change follows up on #1865, which adds caching support. VSCode suggesting the new `cache` properties were errors when included in the config file. That is because the properties needed to be added to the json schema. Global `cache` property in the `runtime` section which adjacent to `rest`, `graphql`, and `host`. ```json { "runtime": { "cache": { "enabled": false, "ttl-seconds": 5 } } } ``` and per entity alongside `source`, `graphql`, `rest`, and `permissions` ```json { "myEntity": { "cache": { "enabled": false, "ttl-seconds": 5 } } } ``` --------- Co-authored-by: Aniruddh Munde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
How was this tested?