-
Notifications
You must be signed in to change notification settings - Fork 274
Feature Flag for Nested Mutations: CLI changes #1983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
severussundar
merged 30 commits into
dev/NestedMutations
from
dev/shyamsundarj/adds-feature-flag-cli-option
Mar 12, 2024
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
9d8bccf
adds feature flag for nested mutations
severussundar 76d7a0b
updates schema file, adds tests
severussundar 5a09b89
updates ref config files, adds method and class descriptions
severussundar c54e454
updates parsing logic to handle env vars, fixes tests
severussundar e4413bc
updates insert => create
severussundar 49b5ab0
fixes tests after rename to create
severussundar 9b803c6
renames the option to use create instead of insert
severussundar f361623
updates sample config files
severussundar a241277
addressing review comments
severussundar cf35d11
fixing tests
severussundar 3a64a47
Merge branch 'main' into dev/shyamsundarj/adds-feature-flag-cli-option
severussundar 156ecb5
adds a sanity test to ensure old config works
severussundar 122241c
updates graphqlql runtime initialization logic
severussundar a78426c
adds test summary, test category
severussundar 7eb21a1
adds logic to not write out nested mutation open when null
severussundar c4898cc
updates tests
severussundar 82b1cce
incorporating review feedback
severussundar 23295bf
adds deserialization tests for invalid values in nested mutation section
severussundar 2e85aee
updates reference config files with true
severussundar 539e6c7
updates test description
severussundar b4ce4b0
fixing snapshot files
severussundar b480c27
adds additionalProperties to draft schema file
severussundar ffcc893
simplifies logic in a helper function
severussundar 6a7b029
updates test descriptions
severussundar ef7c3ef
Merge branch 'dev/NestedMutations' into dev/shyamsundarj/adds-feature…
severussundar 02aa7b6
updating snapshot files as per latest
severussundar 03af546
incorporating review comments
severussundar dd034f8
fixing typo in variable name
severussundar 8968bef
removing fields from non-mssql db ref config files
severussundar 8545c01
incorporates review comments
severussundar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
...ests.VerifyCorrectConfigGenerationWithNestedMutationOptions_09cf40a5c545de68.verified.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| DataSource: { | ||
| Options: { | ||
| container: testcontainer, | ||
| database: testdb, | ||
| schema: test-schema.gql | ||
| } | ||
| }, | ||
| Runtime: { | ||
| Rest: { | ||
| Enabled: false, | ||
| Path: /api, | ||
| RequestBodyStrict: true | ||
| }, | ||
| GraphQL: { | ||
| Enabled: true, | ||
| Path: /graphql, | ||
| AllowIntrospection: true | ||
severussundar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| Host: { | ||
| Cors: { | ||
| Origins: [ | ||
| http://localhost:3000, | ||
| http://nolocalhost:80 | ||
| ], | ||
| AllowCredentials: false | ||
| }, | ||
| Authentication: { | ||
| Provider: StaticWebApps | ||
| } | ||
| } | ||
| }, | ||
| Entities: [] | ||
| } | ||
33 changes: 33 additions & 0 deletions
33
...ests.VerifyCorrectConfigGenerationWithNestedMutationOptions_1211ad099a77f7c4.verified.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| DataSource: { | ||
| DatabaseType: MSSQL, | ||
| Options: { | ||
| set-session-context: true | ||
| } | ||
| }, | ||
| Runtime: { | ||
| Rest: { | ||
| Enabled: true, | ||
| Path: /rest-api, | ||
| RequestBodyStrict: true | ||
| }, | ||
| GraphQL: { | ||
| Enabled: true, | ||
| Path: /graphql, | ||
| AllowIntrospection: true | ||
| }, | ||
| Host: { | ||
| Cors: { | ||
| Origins: [ | ||
| http://localhost:3000, | ||
| http://nolocalhost:80 | ||
| ], | ||
| AllowCredentials: false | ||
| }, | ||
| Authentication: { | ||
| Provider: StaticWebApps | ||
| } | ||
| } | ||
| }, | ||
| Entities: [] | ||
| } |
38 changes: 38 additions & 0 deletions
38
...ests.VerifyCorrectConfigGenerationWithNestedMutationOptions_17721ef496526b3e.verified.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| DataSource: { | ||
| DatabaseType: MSSQL, | ||
| Options: { | ||
| set-session-context: true | ||
| } | ||
| }, | ||
| Runtime: { | ||
| Rest: { | ||
| Enabled: true, | ||
| Path: /rest-api, | ||
| RequestBodyStrict: true | ||
| }, | ||
| GraphQL: { | ||
| Enabled: true, | ||
| Path: /graphql, | ||
| AllowIntrospection: true, | ||
| NestedMutationOptions: { | ||
| NestedCreateOptions: { | ||
| Enabled: true | ||
| } | ||
| } | ||
| }, | ||
| Host: { | ||
| Cors: { | ||
| Origins: [ | ||
| http://localhost:3000, | ||
| http://nolocalhost:80 | ||
| ], | ||
| AllowCredentials: false | ||
| }, | ||
| Authentication: { | ||
| Provider: StaticWebApps | ||
| } | ||
| } | ||
| }, | ||
| Entities: [] | ||
| } |
34 changes: 34 additions & 0 deletions
34
...ests.VerifyCorrectConfigGenerationWithNestedMutationOptions_181195e2fbe991a8.verified.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| DataSource: { | ||
| Options: { | ||
| container: testcontainer, | ||
| database: testdb, | ||
| schema: test-schema.gql | ||
| } | ||
| }, | ||
| Runtime: { | ||
| Rest: { | ||
| Enabled: false, | ||
| Path: /api, | ||
| RequestBodyStrict: true | ||
| }, | ||
| GraphQL: { | ||
| Enabled: true, | ||
| Path: /graphql, | ||
| AllowIntrospection: true | ||
| }, | ||
| Host: { | ||
| Cors: { | ||
| Origins: [ | ||
| http://localhost:3000, | ||
| http://nolocalhost:80 | ||
| ], | ||
| AllowCredentials: false | ||
| }, | ||
| Authentication: { | ||
| Provider: StaticWebApps | ||
| } | ||
| } | ||
| }, | ||
| Entities: [] | ||
| } |
30 changes: 30 additions & 0 deletions
30
...ests.VerifyCorrectConfigGenerationWithNestedMutationOptions_1a73d3cfd329f922.verified.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| { | ||
| DataSource: { | ||
| DatabaseType: MySQL | ||
| }, | ||
| Runtime: { | ||
| Rest: { | ||
| Enabled: true, | ||
| Path: /rest-api, | ||
| RequestBodyStrict: true | ||
| }, | ||
| GraphQL: { | ||
| Enabled: true, | ||
| Path: /graphql, | ||
| AllowIntrospection: true | ||
| }, | ||
| Host: { | ||
| Cors: { | ||
| Origins: [ | ||
| http://localhost:3000, | ||
| http://nolocalhost:80 | ||
| ], | ||
| AllowCredentials: false | ||
| }, | ||
| Authentication: { | ||
| Provider: StaticWebApps | ||
| } | ||
| } | ||
| }, | ||
| Entities: [] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.