GraphQL Mutation support for datawarehouse. #1978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohkhann
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
rohkhann
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
seantleonard
approved these changes
Jan 23, 2024
src/Service.Tests/SqlTests/GraphQLMutationTests/DwSqlGraphQLMutationTests.cs
Show resolved
Hide resolved
src/Service.Tests/SqlTests/GraphQLMutationTests/DwSqlGraphQLMutationTests.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
vadeveka
approved these changes
Jan 23, 2024
|
/azp run |
|
Azure Pipelines successfully started running 5 pipeline(s). |
Aniruddh25
reviewed
Jan 24, 2024
Aniruddh25
reviewed
Jan 24, 2024
Aniruddh25
reviewed
Jan 24, 2024
Aniruddh25
reviewed
Jan 24, 2024
Aniruddh25
reviewed
Jan 24, 2024
Aniruddh25
reviewed
Jan 24, 2024
| string entityName = outputType.TypeName(); | ||
| ObjectType _underlyingFieldType = GraphQLUtils.UnderlyingGraphQLEntityType(outputType); | ||
|
|
||
| if (GraphQLUtils.TryExtractGraphQLFieldModelName(_underlyingFieldType.Directives, out string? modelName)) |
There was a problem hiding this comment.
See this is exactly what we can do in SqlQueryStructure too
Aniruddh25
reviewed
Jan 25, 2024
|
Opened 2 closed conversations to resolve: |
rohkhann
added a commit
that referenced
this pull request
Feb 16, 2024
## Why make this change? Fixing nit comments from earlier pr: #1978 ## What is this change? There were some nit comments to fix while adding implementation for mutation support for DW. ## How was this tested? Existing tests should cover as this pr only handles nit fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Issue: #1976.
GraphQL Mutations need to be supported for data warehouse. Reasons for listed changes listed in issue document.
This pr does not cover REST addition for insert/patch etc. Will be done in following pr's . issue tracking: #1982
What is this change?
How was this tested?
Performed integration tests:
Unit tests added for all dw scenarios.