Skip to content

Conversation

@abhishekkumams
Copy link
Contributor

@abhishekkumams abhishekkumams commented Jan 11, 2024

Why make this change?

  • Cleanup CliBoolean class as it is not adding any value and creating confusion with CliBool.cs

How was this tested?

  • Existing tests

@abhishekkumams
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making this change. I'm assuming CliBoolean was added by mistake at some point?

@abhishekkumams
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@abhishekkumams
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@abhishekkumams
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@abhishekkumams
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@abhishekkumams abhishekkumams merged commit 95549b1 into main Jan 15, 2024
@abhishekkumams abhishekkumams deleted the dev/abhishekkuma/refactor_cli_bool branch January 15, 2024 11:16
@abhishekkumams abhishekkumams self-assigned this Jan 25, 2024
@abhishekkumams abhishekkumams added this to the 0.11rc milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants