fixing datetime and bit issue in DW. #1931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohkhann
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
aaronburtle
reviewed
Dec 16, 2023
Co-authored-by: aaronburtle <[email protected]>
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
…/data-api-builder into rohkhann/DwDatatimeSupport
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
abhishekkumams
approved these changes
Dec 18, 2023
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Datawarehouse was having issues with datetime. This is because we are using string agg. if we dont add the "" to datetime, it is being deserialized as a number and we get a bug saying there is a - in the number. FOR JSON converts bit to true or false and hence we need to do same.
What is this change?
Hence for datetime we need to add the wrapping "" to ensure correct deserialization.
if datatype is bit set to true or false.
How was this tested?
unit tests added.
![Uploading image.png…]()
integration test done with dab running and dw datetime supported. image: