Adding validation to disallow multiple relationships between same source and target entities #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce and target entities
ayush3797
changed the base branch from
main
to
dev/agarwalayush/schemaGeneration
ayush3797
requested review from
mbhaskar,
Aniruddh25,
JelteF,
seantleonard,
Mathos1432,
gledis69,
aaronburtle,
milismsft,
tarazou9,
abhishekkumams,
aaronpowell,
severussundar and
ravishetye
as code owners
ayush3797
changed the base branch from
dev/agarwalayush/schemaGeneration
to
dev/NestedMutations
It will run both for start and validate command |
abhishekkumams
previously approved these changes
Dec 18, 2023
abhishekkumams
dismissed
their stale review
need clarification on some questions
Aniruddh25
approved these changes
Jan 3, 2024
seantleonard
approved these changes
Feb 6, 2024
abhishekkumams
approved these changes
Feb 7, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
seantleonard
approved these changes
Feb 9, 2024
seantleonard
deleted the
dev/agarwalayush/validationForDuplicateRelationships
branch
ayush3797
restored the
dev/agarwalayush/validationForDuplicateRelationships
branch
|
This PR was not to be merged yet. I and @Aniruddh25 had a discussion around this where we decided that throwing an exception at the startup would not be ideal. Rather, we will throw an exception during request execution. As for startup, a warning would suffice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Currently, we allow defining multiple relationships between the same source and target entities. A user is allowed to define multiple relationships each with different source fields/target fields and even different cardinalities. This is not only logically incorrect and difficult to make sense out of, but will also pose a problem in the functioning of nested mutations.
What is this change?
Added the above explained validation in
developmentmode whenGraphQL is enabledfor the source entity..How was this tested?
RuntimeConfigValidator.TestMultipleRelationshipsBetweenSourceAndTargetEntities.