Verifying the read access of anonymous users prior to transmitting the Mutation result. #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neeraj-sharma2592
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Contributor
There was a problem hiding this comment.
Need to add tests. After feedback, the format of the error message is slightly changed to include the mutation operation name as well. Please refer to this PR for the latest format
seantleonard
requested changes
Nov 27, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
need tests too. @neeraj-sharma2592
neeraj-sharma2592
force-pushed
the
dev/neesharma/cosmos-read-permission-check-on-mutation
branch
from
dc0d72d to
67ac50e
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
severussundar
requested changes
Dec 11, 2023
Contributor
severussundar
left a comment
severussundar
left a comment
There was a problem hiding this comment.
Looks good for the most part. Some suggestions around re-using helper functions and few nits in tests
seantleonard
approved these changes
Dec 15, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
thanks for updating with this behavior and addressing feedback!
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
neeraj-sharma2592
deleted the
dev/neesharma/cosmos-read-permission-check-on-mutation
branch
1 task
seantleonard
added a commit
that referenced
this pull request
Feb 6, 2024
…ce options #1980 (#2016) // only diff is excluded changes from mutationtests.cs for Cosmos that only exists in .11+. via #1893 ## Why make this change? - Closes #1956 - env variable replacement not happening in the `options` section of `data-source` property in our config. ## What is this change? - Added a DataSourceConverterFactory which will properly deserialize the data-source section considering the _replaceEnvVariable to decide weather to transform or not. ## How was this tested? - [X] Unit Tests --------- Co-authored-by: Abhishek Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Resolves #1464 for CosmosDB.
What is this change?
Verifying the read access of anonymous users prior to transmitting the Mutation result
How was this tested?