-
Notifications
You must be signed in to change notification settings - Fork 285
fix init command with environment variable #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
seantleonard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and suggestions for simplification
seantleonard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! also for addressing comment, very clean. Appreciate the ability to see full file path in the logs, will help us/PMs/customers troubleshoot if necessary!
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after fixing some corner cases.
Why make this change?
What is this change?
How was this tested?
Sample Request(s)
dab init --database-type mssqlabove command will create:
dab-config.json
dab-config.Development.json