Add support for Cosmos field level auth #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tarazou9 merged 36 commits into main from users/tarazou/CosmosFieldAuth

May 11, 2023

Contributor

tarazou9 commented May 2, 2023 •

edited by Aniruddh25

Loading

Why make this change?

Closes Getting Access forbidden message when trying to use filter on graphql queries #1434, related discussion Getting Access forbidden message when trying to use filter on graphql queries #1423 .
- Changes to add support for Cosmos to check field level auth for query filter and query nested filter.
- Changes to add support for Cosmos to check field level auth for mutation operation.
- Note: current mutation field auth support only check one level down, will have a follow up PR to check nested field auth for mutations.

What is this change?

Enable GraphQLFilterParser for Cosmos.
Resolve WILDCARD and parse all the columns from schema.gql
Parse Included and Excluded columns from runtime config by injecting AuthorizationResolver into the CosmosMutationEngine to make a call to check the columns.

How was this tested?

Integration Tests
Unit Tests

tarazou9 added 3 commits

May 2, 2023 00:04


          Add field auth support for Cosmos

25d29b3


          Fix unit tests

259e880


          Support nested filter field auth

ca2a117

tarazou9 requested review from Aniruddh25, JelteF, Mathos1432, aaronburtle, aaronpowell, abhishekkumams, ayush3797, gledis69, mbhaskar, milismsft, ravishetye, seantleonard and severussundar as code owners

May 2, 2023 22:43

tarazou9 added 2 commits

May 2, 2023 18:46


          Merge branch 'main' into users/tarazou/CosmosFieldAuth

96545c1


          Fix format

edde2ee

This comment was marked as outdated.

Sign in to view

tarazou9 added 3 commits

May 3, 2023 16:44


          Debug the Ci failure

7ae2d65


          add debugging msg

9ebd275


          debug cli error

ca12766

Aniruddh25 reviewed

View reviewed changes

src/Service/Models/GraphQLFilterParsers.cs Outdated Show resolved Hide resolved


          Fix cli error

c067a4d

Aniruddh25 reviewed

View reviewed changes

src/Service/Services/MetadataProviders/CosmosSqlMetadataProvider.cs Outdated Show resolved Hide resolved

Aniruddh25 reviewed

View reviewed changes

src/Service.Tests/dab-config.CosmosDb_NoSql.json Outdated Show resolved Hide resolved

Aniruddh25 reviewed

View reviewed changes

src/Service/Services/MetadataProviders/CosmosSqlMetadataProvider.cs Outdated Show resolved Hide resolved

Aniruddh25 reviewed

View reviewed changes

src/Service/Resolvers/CosmosMutationEngine.cs Show resolved Hide resolved

tarazou9 added 2 commits

May 3, 2023 18:28


          Fix cli error

4f70b29


          Remove debugging msg

2fb81f6

tarazou9 added 4 commits

May 9, 2023 16:41


          debug intergration test

0363aef


          debug interagtion test

6768b14


          debug intergration tests

f902b17


          put test back

seantleonard reviewed

View reviewed changes

src/Service.Tests/CosmosTests/TestBase.cs Outdated Show resolved Hide resolved

Aniruddh25 reviewed

View reviewed changes

src/Service/Services/GraphQLSchemaCreator.cs Outdated Show resolved Hide resolved

Aniruddh25 requested changes

View reviewed changes

Collaborator

Aniruddh25 left a comment

Thank for implementing this new feature! Few more concerns then its good to go

tarazou9 added 3 commits

May 10, 2023 11:07


          Fix issues

b1b4b47


          Add test

eeda5c7


          Refactored

269cf61

seantleonard reviewed

View reviewed changes

Contributor

seantleonard left a comment

nits on naming/comments to clarify intent.

src/Service/Services/MetadataProviders/CosmosSqlMetadataProvider.cs Outdated Show resolved Hide resolved

src/Service.Tests/CosmosTests/QueryFilterTests.cs Outdated Show resolved Hide resolved

src/Service/Models/GraphQLFilterParsers.cs Outdated Show resolved Hide resolved

src/Service/Models/GraphQLFilterParsers.cs Outdated Show resolved Hide resolved

src/Service/Services/MetadataProviders/CosmosSqlMetadataProvider.cs Outdated Show resolved Hide resolved

src/Service/Services/MetadataProviders/CosmosSqlMetadataProvider.cs Outdated Show resolved Hide resolved

seantleonard reviewed

View reviewed changes

Contributor

seantleonard left a comment

last nit, otherwise looks good!

src/Service/Services/MetadataProviders/CosmosSqlMetadataProvider.cs Outdated Show resolved Hide resolved

Aniruddh25 reviewed

View reviewed changes

src/Service/Services/MetadataProviders/CosmosSqlMetadataProvider.cs Outdated Show resolved Hide resolved


          Updated comments

cbf27cc

Aniruddh25 reviewed

View reviewed changes

config-generators/cosmosdb_nosql-commands.txt Show resolved Hide resolved

Aniruddh25 reviewed

View reviewed changes

src/Service.Tests/CosmosTests/TestBase.cs Show resolved Hide resolved

Aniruddh25 approved these changes

View reviewed changes

Collaborator

Aniruddh25 left a comment

LGTM! Thanks for the contributions :)

seantleonard approved these changes

View reviewed changes

src/Service.Tests/CosmosTests/QueryFilterTests.cs Outdated Show resolved Hide resolved

src/Service.Tests/CosmosTests/QueryFilterTests.cs Outdated Show resolved Hide resolved

abhishekkumams reviewed

View reviewed changes

src/Service/Resolvers/CosmosMutationEngine.cs Outdated Show resolved Hide resolved

abhishekkumams approved these changes

View reviewed changes

abhishekkumams and others added 4 commits

May 11, 2023 11:05


          Merge branch 'main' into users/tarazou/CosmosFieldAuth

c6af52a


          Address PR comments

107e58e


          Merge branch 'users/tarazou/CosmosFieldAuth' of https://github.com/Az…

f71051c

…ure/data-api-builder into users/tarazou/CosmosFieldAuth


          wrapped try catch

bc567df

tarazou9 enabled auto-merge (squash)

May 11, 2023 16:09

tarazou9 merged commit f3eac1f into main

tarazou9 deleted the users/tarazou/CosmosFieldAuth branch

May 11, 2023 16:11

Aniruddh25 mentioned this pull request

[Bug]: Insufficient permissions error when accessing table with appropriate role #1483

Closed

1 task

Aniruddh25 mentioned this pull request

[Bug]: Using the word Asset as a model returns an error in version 0.7.6 #1538

Closed

1 task

tarazou9 mentioned this pull request

[Bug]: Using filter on multi-level nested objects causes runtime error (GraphQL, CosmosDB) #1628

Closed

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Aniruddh25 Aniruddh25 approved these changes

seantleonard seantleonard approved these changes

mbhaskar Awaiting requested review from mbhaskar

JelteF Awaiting requested review from JelteF

Mathos1432 Awaiting requested review from Mathos1432

gledis69 Awaiting requested review from gledis69

aaronburtle Awaiting requested review from aaronburtle aaronburtle is a code owner

milismsft Awaiting requested review from milismsft

ayush3797 Awaiting requested review from ayush3797

aaronpowell Awaiting requested review from aaronpowell

severussundar Awaiting requested review from severussundar

ravishetye Awaiting requested review from ravishetye

+1 more reviewer

abhishekkumams abhishekkumams approved these changes

Labels

None yet