Skip to content

Address filter access deny issue for Cosmos #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Address filter access deny issue for Cosmos #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
906dda6
Address filter access deny issue for Cosmos
tarazou9 Apr 13, 2023
4a22757
Remove extra whitespace
tarazou9 Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Service.Tests/CosmosTests/TestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public static void Init(TestContext context)
It.IsAny<string>(),
It.IsAny<Config.Operation>(),
It.IsAny<IEnumerable<string>>()
)).Returns(true);
)).Returns(false);

_application = new WebApplicationFactory<Startup>()
.WithWebHostBuilder(builder =>
Expand Down
5 changes: 3 additions & 2 deletions src/Service/Models/GraphQLFilterParsers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,11 @@ public Predicate Parse(
relationshipField = false;
}

// Only perform field (column) authorization when the field is not a relationship field.
// Only perform field (column) authorization when the field is not a relationship field and when the database type is not Cosmos DB.
// Currently Cosmos DB doesn't support field level authorization.
// Due to the recursive behavior of SqlExistsQueryStructure compilation, the column authorization
// check only occurs when access to the column's owner entity is confirmed.
if (!relationshipField)
if (!relationshipField && _metadataProvider.GetDatabaseType() is not DatabaseType.cosmosdb_nosql)
{
string targetEntity = queryStructure.EntityName;

Expand Down
3 changes: 2 additions & 1 deletion src/Service/Services/MetadataProviders/CosmosSqlMetadataProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ public bool VerifyForeignKeyExistsInDB(

public bool TryGetExposedColumnName(string entityName, string field, out string? name)
{
throw new NotImplementedException();
name = field;
return true;
}

/// <summary>
Expand Down