storageAsyncResult.End(); throws NullReferenceException.. most times.

[mkarlsson]

Running the following code some images work to upload and others don't. I have tried to figure out what differs them but an image that works to upload can later fail and vice versa.

This is the code I use to upload blobs:

public async Task UploadAndSaveBlobAsync(string adId, IFormFile imageFile, string fileName){
            var blobName = adId + "/" + fileName;
            await _container.CreateIfNotExistsAsync();
            await _container.SetPermissionsAsync(new BlobContainerPermissions
            {
                PublicAccess = BlobContainerPublicAccessType.Blob
            });
            var blockBlob = _container.GetBlockBlobReference(blobName);
            blockBlob.Properties.ContentType = imageFile.ContentType;

            try
            {
                using (var stream = imageFile.OpenReadStream())
                {
                    await blockBlob.UploadFromStreamAsync(stream);
                }
            }
            catch (Exception e)
            {
                Trace.TraceError("Could not upload image" + e.Message);
                throw;
            }

            var blobsName = blockBlob.Uri.ToString();

        }

/End example code

And here is the StackTrace for ""Object reference not set to an instance of an object."

" at Microsoft.WindowsAzure.Storage.Core.Util.StorageAsyncResult`1.End() in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Core\Util\StorageAsyncResult.cs:line 77\r\n at Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob.EndUploadFromStream(IAsyncResult asyncResult) in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Blob\CloudBlockBlob.cs:line 739\r\n at Microsoft.WindowsAzure.Storage.Core.Util.AsyncExtensions.<>c__DisplayClass4.b__3(IAsyncResult ar) in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Core\Util\AsyncExtensions.cs:line 114\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.GetResult()\r\n at Mulimo.DAL.BlobStorage.d__7.MoveNext() in C:\Source\Mulimo\src\Mulimo.DAL\BlobStorage.cs:line 70"

[pemari-msft]

Hi, can you clarify what platform you're targeting? Can you give us some information to help us try to repro (I wasn't able to myself).

Thanks!

[mkarlsson]

Hi, here is the project.json from my DAL lib.
{
"version": "1.0.0-*",
"description": "Mulimo.DAL Class Library",
"authors": [ "Magnus" ],
"tags": [ "" ],
"projectUrl": "",
"licenseUrl": "",
"dependencies": {
"Mulimo.Domain": "",
"Mulimo.DALInterfaces": "",
"WindowsAzure.Storage": "6.1.0",
"Microsoft.AspNet.Hosting.Abstractions": "1.0.0-rc1-final",
"Microsoft.Extensions.PlatformAbstractions": "1.0.0-rc1-final",
"Microsoft.Extensions.Configuration": "1.0.0-rc1-final",
"Microsoft.Extensions.Configuration.FileExtensions": "1.0.0-rc1-final",
"Microsoft.Extensions.Configuration.Json": "1.0.0-rc1-final",
"Microsoft.Extensions.Configuration.EnvironmentVariables": "1.0.0-rc1-final",
"Microsoft.Extensions.DependencyInjection.Abstractions": "1.0.0-rc1-final"
},
"frameworks": {
"net451": { }
}
}

[mkarlsson]

Here is the BlobStorage file

public class BlobStorage : IBlobStorage
    {
        CloudBlobClient _blobClient;
        CloudBlobContainer _container;
        public IConfigurationRoot Configuration { get; set; }

        public BlobStorage(IHostingEnvironment env, IApplicationEnvironment appEnv)
        {
            var builder = new ConfigurationBuilder()
                .AddJsonFile("appsettings.json")
                .AddJsonFile($"appsettings.{env.EnvironmentName}.json", optional: true);


            builder.AddEnvironmentVariables();
            Configuration = builder.Build();

            CloudStorageAccount storageAccount = CloudStorageAccount.Parse(
  Configuration["MicrosoftAzureStorage:fake_AzureStorageConnectionString"]);

            // Create a blob client.
            _blobClient = storageAccount.CreateCloudBlobClient();
            _blobClient.DefaultRequestOptions.RetryPolicy = new LinearRetry(TimeSpan.FromSeconds(3), 3);

            _container = _blobClient.GetContainerReference("images");

            _container.CreateIfNotExistsAsync();
        }

        public async Task UploadAndSaveBlobAsync(string adId, IFormFile imageFile, string fileName)
        {
            var blobName = adId + "/" + fileName;
            await _container.CreateIfNotExistsAsync();
            await _container.SetPermissionsAsync(new BlobContainerPermissions
            {
                PublicAccess = BlobContainerPublicAccessType.Blob
            });
            //Get reference to a blob

            var blockBlob = _container.GetBlockBlobReference(blobName);
            blockBlob.Properties.ContentType = imageFile.ContentType;

            try
            {
                using (var stream = imageFile.OpenReadStream())
                {
                    await blockBlob.UploadFromStreamAsync(stream);
                }
            }
            catch (Exception e)
            {
                Trace.TraceError("Could not upload image" + e.Message);
                throw;
            }

            var blobsName = blockBlob.Uri.ToString();

        }

        static byte[] GetBytes(string str)
        {
            byte[] bytes = new byte[str.Length * sizeof(char)];
            System.Buffer.BlockCopy(str.ToCharArray(), 0, bytes, 0, bytes.Length);
            return bytes;
        }

        public async Task<bool> AddToBlob(string folder, string name)
        {

            // Get a reference to a blob named "myblob".
            CloudBlockBlob blockBlob = _container.GetBlockBlobReference("myblob");

            // Create or overwrite the "myblob" blob with the contents of a local file
            // named “myfile”.
            using (var fileStream = File.OpenRead(@"path\myfile"))
            {
                await blockBlob.UploadFromStreamAsync(fileStream);
            }
            return true;
        }

    }

[mkarlsson]

Current situation is the following image work
https://dl.dropboxusercontent.com/u/1052402/storageerror/WIN_20151118_13_39_14_Pro.jpg
(This is a picture from my camera roll of Ryan @msft)
and this one does not.
https://dl.dropboxusercontent.com/u/1052402/storageerror/bild3.jpg
(random picture of Volvo S60 )

[pemari-msft]

Hi @mkarlsson , it seems from your project.json file that you're taking a dependency on our GA library (which doesn't support DNX 4.5.1 or DNX Core 5.0) and that you're looking to use it on the DNX 4.5.1 or DNX Core 5.0 1.0.0-rc1 bits. Can you confirm this?

If so, please take a look at our readme, and especially the Versioning Info Section.

If you want to use our CoreCLR/DNX4.5.1 library, please take a look at our 6.1.1-preview package and please note that we currently support up to beta8 and are working to update to rc1 soon.

Thanks!

[mkarlsson]

Yes, I'm targeting dnx 4.5.1. so I'm really looking forward to the upcoming rc1 release now. You think you'll get it out this week, next week, or next month?

You can go ahead and close this issue btw.

Cheers!

[mkarlsson]

I just installed "WindowsAzure.Storage": "6.2.2-preview", and get the same error as earlier. I have a brand new setup(SPRO4) with VS2015 Enterprise and the latest piece of DNX. I don't target core54.

In my comment 19 days ago I found I can post one image but not the other. That example is true even now.

This is the stacktrace error from my catch clause.

at Microsoft.WindowsAzure.Storage.Core.Util.StorageAsyncResult`1.End() in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Core\Util\StorageAsyncResult.cs:line 77
at Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob.EndUploadFromStream(IAsyncResult asyncResult) in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Blob\CloudBlockBlob.cs:line 739
at Microsoft.WindowsAzure.Storage.Core.Util.AsyncExtensions.<>c__DisplayClass4.b__3(IAsyncResult ar) in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Core\Util\AsyncExtensions.cs:line 114
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
at Mulimo.DAL.BlobStorage.d__7.MoveNext() in C:\Source\Mulimo\src\Mulimo.DAL\BlobStorage.cs:line 70

[mkarlsson]

ping

[pemari-msft]

Hi @mkarlsson,

I'm still not able to repro the issue. If you're targeting DNX and not Core, the dll has actually changed from 6.1.1-preview to 6.2.2-preview so it's not even the same code running anymore. The 'upload a blob' case is one of our most basic tests, so this must definitely be a particular scenario that's failing. You say you can upload one image but not another? What's the difference between them? Can you provide us a small repro app?

[zapthedingbat]

I am seeing this exception intermittently. I'm using WindowsAzure.Storage 6.1.1-preview

NullReferenceException: Object reference not set to an instance of an object.
Microsoft.WindowsAzure.Storage.Core.Util.StorageAsyncResult`1.End() in StorageAsyncResult.cs, line 75


NullReferenceException: Object reference not set to an instance of an object.
Microsoft.WindowsAzure.Storage.Core.Util.StorageAsyncResult`1.End() in StorageAsyncResult.cs
Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob.EndUploadFromStream(IAsyncResult asyncResult) in CloudBlockBlob.cs
Microsoft.WindowsAzure.Storage.Core.Util.AsyncExtensions.<>c__DisplayClass4.<CreateCallbackVoid>b__3(IAsyncResult ar) in AsyncExtensions.cs
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
RadicalResearch.Narrator.Website.Controllers.AudioController.<Post>d__2.MoveNext() in AudioController.cs
                blobName = string.Concat(audioPost.Word.ToUpperInvariant(), ".", index);
                blockBlob = container.GetBlockBlobReference(blobName);
            }
            using (var stream = audioPost.File.OpenReadStream())
            {
                await blockBlob.UploadFromStreamAsync(stream);
            }
            // Add transcode message to queue
            var queueClient = storageAccount.CreateCloudQueueClient();
            var queue = queueClient.GetQueueReference("audio-transcode");
            await queue.AddMessageAsync(new CloudQueueMessage(blobName));
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
Microsoft.AspNet.Mvc.Controllers.ControllerActionExecutor.<CastToObject>d__7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
Microsoft.AspNet.Mvc.Controllers.ControllerActionInvoker.<InvokeActionAsync>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
Microsoft.AspNet.Mvc.Controllers.FilterActionInvoker.<InvokeActionFilterAsync>d__53.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
Microsoft.AspNet.Mvc.Controllers.FilterActionInvoker.<InvokeAsync>d__44.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
Microsoft.AspNet.Mvc.Infrastructure.MvcRouteHandler.<RouteAsync>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
Microsoft.AspNet.Mvc.Routing.InnerAttributeRoute.<RouteAsync>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
Microsoft.AspNet.Routing.RouteCollection.<RouteAsync>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
Microsoft.AspNet.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
Microsoft.AspNet.IISPlatformHandler.IISPlatformHandlerMiddleware.<Invoke>d__8.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
Microsoft.AspNet.Diagnostics.DeveloperExceptionPageMiddleware.<Invoke>d__7.MoveNext()

Show raw exception details
No QueryString data.

No cookie data.

Variable    Value
Accept  */*
Accept-Encoding gzip, deflate
Accept-Language en-GB,en;q=0.8,en-US;q=0.6
Connection  Keep-Alive
Content-Length  94480
Content-Type    multipart/form-data; boundary=----WebKitFormBoundaryku1o4URnk5FPgGBH
DNT 1
Host    localhost:5000
Origin  http://localhost:5000
Referer http://localhost:5000/
User-Agent  Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36
X-Forwarded-For [::1]:10597
X-Forwarded-Proto   http
X-Original-Proto    http

Github repo with code is available:

https://github.com/RadicalResearch/narrator/blob/master/RadicalResearch.Narrator.Website/Controllers/AudioController.cs#L48

The error is reproducible here https://narrator.radicalresearch.co.uk/ (although you will have to record a sound and monitor the response of the AJAX post)

[pemari-msft]

Interesting. And does it repro on 6.2.2-preview? I am unable to repro it myself and we have tests that we run before each release that upload hundreds if not thousands of blobs. Are you able to repro the behavior in a small sample console app separately from your larger codebase?

[zapthedingbat]

The same issue manifests in 6.2.2-preview.

I can't reproduce it in a Console app, but the exception is being thrown in an ASP.NET controller, perhaps its specific to the synchronization context being used?

[duanjian]

hi @pemari-msft aspnet/HttpAbstractions#517 (comment) the same issue.