Sync eng/common directory with azure-sdk-tools for PR 12337 #3111
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools for PR #12337, specifically restoring error handling behavior that was changed in a previous PR. The change ensures that Write-Error is called in CI environments when commands fail, reproducing the behavior that existed before PR #12235.
Key changes:
- Restores
Write-Errorinvocation in CI environments for failed commands - Adds explanatory comments about the behavioral change and its rationale
danieljurek
approved these changes
Oct 3, 2025
azure-sdk
deleted the
sync-eng/common-djurek/fix-invoke-logged-command-12337
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12337 See eng/common workflow