Skip to content

Conversation

vincenttran-msft
Copy link
Member

@vincenttran-msft vincenttran-msft commented Oct 2, 2025

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Oct 2, 2025
}

impl GeneratedBlobClient {
fn from_url(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be able to use #[tracing::new] here - it should work and hide the tracer initialization.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Larry, that works out much cleaner! However, this requires us to make the from_url function on the underlying GeneratedBlobClient now public (which is not desired as everything should go through our convenience layer).

This is not yet the final design, so Storage will discuss internally and ensure we land on our final design before requesting any Core code changes (i.e. removing the requirement here that the visibility must be public to utilize the macro)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to resync with main (which may be painful because of Heath's recent changes). He ran into the same issue and we decided that the public requirement wasn't necessary or appropriate.

So changing core is probably the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants