Skip to content

Conversation

chlowell
Copy link
Member

#2933 removed this metadata on the assumption that docs.rs defaults to building with all features, however it actually defaults to building with none (see the docs) with the result that ClientCertificateCredential isn't documented for 0.28.0. This PR fudges the now-broken link to that type's docs so our CI runs can succeed and tells docs.rs to build with the client_certificate feature. I'll unfudge the link after the next release.

@chlowell chlowell self-assigned this Sep 30, 2025
@github-actions github-actions bot added the Azure.Identity The azure_identity crate label Sep 30, 2025
@chlowell chlowell marked this pull request as ready for review September 30, 2025 23:12
@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 23:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes documentation generation for the azure_identity crate by ensuring ClientCertificateCredential is included in docs.rs builds. The issue arose when PR #2933 removed docs.rs metadata assuming all features would be built by default, but docs.rs actually builds with no features by default.

  • Adds docs.rs metadata to build with the "client_certificate" feature
  • Temporarily updates the ClientCertificateCredential documentation link to use a redirect URL

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/identity/azure_identity/Cargo.toml Adds package.metadata.docs.rs configuration to enable client_certificate feature
sdk/identity/azure_identity/README.md Updates ClientCertificateCredential link to temporary redirect URL

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure Identity SDK Improvements Oct 1, 2025
@chlowell chlowell merged commit bbb3031 into Azure:main Oct 1, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure Identity SDK Improvements Oct 1, 2025
@chlowell chlowell deleted the docsrs branch October 1, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Identity The azure_identity crate

Projects

Development

Successfully merging this pull request may close these issues.

2 participants