Skip to content

Conversation

heaths
Copy link
Member

@heaths heaths commented Aug 26, 2025

Follow up to #2933

@heaths heaths requested review from analogrelay, Copilot and demoray and removed request for analogrelay and demoray August 26, 2025 05:14
@github-actions github-actions bot added the Azure.Core The azure_core crate label Aug 26, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for alternative HTTP client configuration following the removal of the reqwest_rustls_tls feature. The changes provide developers with clear guidance on how to customize or replace the default HTTP client implementation.

  • Documents how to configure reqwest with different TLS providers and features
  • Provides a complete example implementation using ureq as an alternative HTTP client
  • Updates changelog entries to reference the new documentation for migration guidance

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/typespec/typespec_client_core/CHANGELOG.md Added breaking change entry referencing new HTTP client configuration docs
sdk/core/azure_core/examples/core_ureq_client.rs Complete example showing how to implement HttpClient trait for ureq
sdk/core/azure_core/README.md Extensive documentation on replacing/configuring HTTP clients with examples
sdk/core/azure_core/Cargo.toml Added dev dependencies for the new example
sdk/core/azure_core/CHANGELOG.md Added breaking change entry with documentation reference
eng/scripts/verify-dependencies.rs Added exemptions for new dev dependencies
eng/dict/crates.txt Added ureq to dictionary
.vscode/cspell.json Added crates dictionary for markdown files

@heaths heaths enabled auto-merge (squash) August 26, 2025 19:13
@heaths heaths merged commit ae75d3b into Azure:main Aug 26, 2025
17 checks passed
@heaths heaths deleted the feature-docs branch August 26, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core The azure_core crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants