Skip to content

Conversation

m7md7sien
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@m7md7sien m7md7sien requested a review from a team as a code owner October 5, 2025 16:42
@Copilot Copilot AI review requested due to automatic review settings October 5, 2025 16:42
Copy link

github-actions bot commented Oct 5, 2025

Thank you for your contribution @m7md7sien! We will review the pull request and get back to you soon.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Evaluation Issues related to the client library for Azure AI Evaluation labels Oct 5, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the Path Efficiency Evaluator to Task Navigation Efficiency Evaluator and changes its API to return only one metric based on a configurable matching mode instead of multiple threshold-based metrics.

Key changes include:

  • Replaced threshold-based scoring with a single matching mode parameter
  • Changed return format to include a single binary result with additional properties
  • Updated all related documentation, samples, and tests

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test_task_navigation_efficiency_evaluators.py New test file implementing comprehensive tests for the renamed evaluator with matching modes
test_path_efficiency_evaluators.py Removed old test file for the deprecated PathEfficiencyEvaluator
evaluation_samples_evaluate_fdp.py Updated sample code to use new TaskNavigationEfficiencyEvaluator API
evaluation_samples_evaluate.py Updated sample code to use new TaskNavigationEfficiencyEvaluator API
task_navigation_efficiency.ipynb Updated notebook documentation with new evaluator name and API
_exceptions.py Added new error target for TaskNavigationEfficiencyEvaluator
task_navigation_efficiency.py Main implementation file with new API design and matching modes
task_navigation_efficiency/init.py New module exports for the renamed evaluator
_path_efficiency/init.py Removed old module exports

@m7md7sien m7md7sien force-pushed the mohessie/refactor_task_navigation_evaluator branch from d4b1ef6 to 2fd5df7 Compare October 5, 2025 17:07
@m7md7sien m7md7sien force-pushed the mohessie/refactor_task_navigation_evaluator branch from 2fd5df7 to bbe5b69 Compare October 5, 2025 18:00
@luigiw luigiw merged commit 65f6f1a into Azure:main Oct 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants