-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Rename Tool Call Accuracy Evaluator to Tool Call Quality #43246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Tool Call Accuracy Evaluator to Tool Call Quality #43246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the Tool Call Accuracy Evaluator to Tool Call Quality Evaluator to better reflect its purpose. The change involves updating class names, file names, constants, and all references throughout the codebase while maintaining backward compatibility through an alias.
- Renamed
ToolCallAccuracyEvaluator
toToolCallQualityEvaluator
across all files - Updated associated constants, messages, and identifiers from "accuracy" to "quality"
- Maintained backward compatibility by keeping the old class name as an alias
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
test_tool_call_quality_evaluator.py | Updated all test class names and references to use the new ToolCallQualityEvaluator |
test_agent_evaluators.py | Updated test method names and evaluator references to use new quality naming |
evaluation_samples_evaluate_fdp.py | Updated sample code to demonstrate new ToolCallQualityEvaluator usage |
evaluation_samples_evaluate.py | Updated sample code to demonstrate new ToolCallQualityEvaluator usage |
tool_call_quality.ipynb | Updated notebook title and content to reflect new quality evaluator naming |
_exceptions.py | Added new TOOL_CALL_QUALITY_EVALUATOR error target enum value |
tool_call_quality.prompty | Updated prompty file name and description from accuracy to quality |
_tool_call_quality.py | Renamed class and all internal references from accuracy to quality terminology |
init.py | Updated imports to use new ToolCallQualityEvaluator class name |
_eval_mapping.py | Added mapping for new evaluator while maintaining backward compatibility |
init.py | Added new evaluator to exports and created backward compatibility alias |
Thank you for your contribution @salma-elshafey! We will review the pull request and get back to you soon. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines