Skip to content

Conversation

allenkim0129
Copy link
Contributor

@allenkim0129 allenkim0129 commented Oct 3, 2025

Description

Tackling the bullet point items related to query_items for GA release: #43211

  • overloads for the query_items methods are all missing return types
  • query_items overloads should be updated to reflect the behavior being outlined here:
Image

@allenkim0129 allenkim0129 requested a review from a team as a code owner October 3, 2025 20:45
@Copilot Copilot AI review requested due to automatic review settings October 3, 2025 20:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses missing return types and parameter requirements for the query_items method overloads in the Azure Cosmos DB SDK, as part of the GA release preparation. The changes ensure type safety and clarify the API contract by making certain parameters required rather than optional.

  • Updates overload signatures to include proper return type annotations
  • Changes partition_key and feed_range parameters from optional to required in specific overloads
  • Adds a new overload for cross-partition queries without partition key or feed range constraints

Copy link

github-actions bot commented Oct 3, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-cosmos

Copy link
Member

@bambriz bambriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just note there might be some merge conflicts with _PartitionKeyType usage as the other pr changes those to be PartitionKeyType, but it shouldn't be a difficult thing to resolve.

@allenkim0129 allenkim0129 merged commit b4d65d3 into Azure:main Oct 6, 2025
21 checks passed
@allenkim0129
Copy link
Contributor Author

LGTM, just note there might be some merge conflicts with _PartitionKeyType usage as the other pr changes those to be PartitionKeyType, but it shouldn't be a difficult thing to resolve.

I tested with merge main branch and it diden't cause conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants