-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[Cosmos] Public API cleanup for query_items
API
#43240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cosmos] Public API cleanup for query_items
API
#43240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses missing return types and parameter requirements for the query_items
method overloads in the Azure Cosmos DB SDK, as part of the GA release preparation. The changes ensure type safety and clarify the API contract by making certain parameters required rather than optional.
- Updates overload signatures to include proper return type annotations
- Changes
partition_key
andfeed_range
parameters from optional to required in specific overloads - Adds a new overload for cross-partition queries without partition key or feed range constraints
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just note there might be some merge conflicts with _PartitionKeyType usage as the other pr changes those to be PartitionKeyType, but it shouldn't be a difficult thing to resolve.
I tested with merge main branch and it diden't cause conflict. |
Description
Tackling the bullet point items related to
query_items
for GA release: #43211query_items
methods are all missing return typesquery_items
overloads should be updated to reflect the behavior being outlined here: