-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Sync eng/common directory with azure-sdk-tools for PR 12301 #43214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools repository, specifically adding new vcpkg cache configuration files. The changes introduce infrastructure for managing vcpkg binary and asset caches, supporting both read-only and read-write access modes depending on the execution context.
- Adds PowerShell script for configuring write-mode vcpkg cache with SAS token generation
- Adds Azure DevOps pipeline template for setting vcpkg cache variables
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
eng/common/scripts/Set-VcpkgWriteModeCache.ps1 | PowerShell script that configures Azure Storage context and generates SAS tokens for vcpkg binary cache with read-write permissions |
eng/common/pipelines/templates/steps/set-vcpkg-cache-vars.yml | Azure DevOps pipeline template that sets vcpkg cache variables for read-only access and conditionally enables write-mode for internal projects |
$moduleSeperator = ";" | ||
} | ||
else { | ||
$hostedAgentModulePath = "/usr/share" | ||
$moduleSeperator = ":" | ||
} | ||
$modulePaths = $env:PSModulePath -split $moduleSeperator | ||
$modulePaths = $modulePaths.Where({ !$_.StartsWith($hostedAgentModulePath) }) | ||
$AzModuleCachePath = (Get-ChildItem "$hostedAgentModulePath/az_*" -Attributes Directory) -join $moduleSeperator | ||
if ($AzModuleCachePath -and $env:PSModulePath -notcontains $AzModuleCachePath) { | ||
$modulePaths += $AzModuleCachePath | ||
} | ||
|
||
$env:PSModulePath = $modulePaths -join $moduleSeperator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name 'moduleSeperator' is misspelled. It should be 'moduleSeparator' (with an 'a' instead of 'e').
$moduleSeperator = ";" | |
} | |
else { | |
$hostedAgentModulePath = "/usr/share" | |
$moduleSeperator = ":" | |
} | |
$modulePaths = $env:PSModulePath -split $moduleSeperator | |
$modulePaths = $modulePaths.Where({ !$_.StartsWith($hostedAgentModulePath) }) | |
$AzModuleCachePath = (Get-ChildItem "$hostedAgentModulePath/az_*" -Attributes Directory) -join $moduleSeperator | |
if ($AzModuleCachePath -and $env:PSModulePath -notcontains $AzModuleCachePath) { | |
$modulePaths += $AzModuleCachePath | |
} | |
$env:PSModulePath = $modulePaths -join $moduleSeperator | |
$moduleSeparator = ";" | |
} | |
else { | |
$hostedAgentModulePath = "/usr/share" | |
$moduleSeparator = ":" | |
} | |
$modulePaths = $env:PSModulePath -split $moduleSeparator | |
$modulePaths = $modulePaths.Where({ !$_.StartsWith($hostedAgentModulePath) }) | |
$AzModuleCachePath = (Get-ChildItem "$hostedAgentModulePath/az_*" -Attributes Directory) -join $moduleSeparator | |
if ($AzModuleCachePath -and $env:PSModulePath -notcontains $AzModuleCachePath) { | |
$modulePaths += $AzModuleCachePath | |
} | |
$env:PSModulePath = $modulePaths -join $moduleSeparator |
Copilot uses AI. Check for mistakes.
$moduleSeperator = ";" | ||
} | ||
else { | ||
$hostedAgentModulePath = "/usr/share" | ||
$moduleSeperator = ":" | ||
} | ||
$modulePaths = $env:PSModulePath -split $moduleSeperator | ||
$modulePaths = $modulePaths.Where({ !$_.StartsWith($hostedAgentModulePath) }) | ||
$AzModuleCachePath = (Get-ChildItem "$hostedAgentModulePath/az_*" -Attributes Directory) -join $moduleSeperator | ||
if ($AzModuleCachePath -and $env:PSModulePath -notcontains $AzModuleCachePath) { | ||
$modulePaths += $AzModuleCachePath | ||
} | ||
|
||
$env:PSModulePath = $modulePaths -join $moduleSeperator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name 'moduleSeperator' is misspelled. It should be 'moduleSeparator' (with an 'a' instead of 'e').
$moduleSeperator = ";" | |
} | |
else { | |
$hostedAgentModulePath = "/usr/share" | |
$moduleSeperator = ":" | |
} | |
$modulePaths = $env:PSModulePath -split $moduleSeperator | |
$modulePaths = $modulePaths.Where({ !$_.StartsWith($hostedAgentModulePath) }) | |
$AzModuleCachePath = (Get-ChildItem "$hostedAgentModulePath/az_*" -Attributes Directory) -join $moduleSeperator | |
if ($AzModuleCachePath -and $env:PSModulePath -notcontains $AzModuleCachePath) { | |
$modulePaths += $AzModuleCachePath | |
} | |
$env:PSModulePath = $modulePaths -join $moduleSeperator | |
$moduleSeparator = ";" | |
} | |
else { | |
$hostedAgentModulePath = "/usr/share" | |
$moduleSeparator = ":" | |
} | |
$modulePaths = $env:PSModulePath -split $moduleSeparator | |
$modulePaths = $modulePaths.Where({ !$_.StartsWith($hostedAgentModulePath) }) | |
$AzModuleCachePath = (Get-ChildItem "$hostedAgentModulePath/az_*" -Attributes Directory) -join $moduleSeparator | |
if ($AzModuleCachePath -and $env:PSModulePath -notcontains $AzModuleCachePath) { | |
$modulePaths += $AzModuleCachePath | |
} | |
$env:PSModulePath = $modulePaths -join $moduleSeparator |
Copilot uses AI. Check for mistakes.
$moduleSeperator = ";" | ||
} | ||
else { | ||
$hostedAgentModulePath = "/usr/share" | ||
$moduleSeperator = ":" | ||
} | ||
$modulePaths = $env:PSModulePath -split $moduleSeperator | ||
$modulePaths = $modulePaths.Where({ !$_.StartsWith($hostedAgentModulePath) }) | ||
$AzModuleCachePath = (Get-ChildItem "$hostedAgentModulePath/az_*" -Attributes Directory) -join $moduleSeperator | ||
if ($AzModuleCachePath -and $env:PSModulePath -notcontains $AzModuleCachePath) { | ||
$modulePaths += $AzModuleCachePath | ||
} | ||
|
||
$env:PSModulePath = $modulePaths -join $moduleSeperator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name 'moduleSeperator' is misspelled. It should be 'moduleSeparator' (with an 'a' instead of 'e').
$moduleSeperator = ";" | |
} | |
else { | |
$hostedAgentModulePath = "/usr/share" | |
$moduleSeperator = ":" | |
} | |
$modulePaths = $env:PSModulePath -split $moduleSeperator | |
$modulePaths = $modulePaths.Where({ !$_.StartsWith($hostedAgentModulePath) }) | |
$AzModuleCachePath = (Get-ChildItem "$hostedAgentModulePath/az_*" -Attributes Directory) -join $moduleSeperator | |
if ($AzModuleCachePath -and $env:PSModulePath -notcontains $AzModuleCachePath) { | |
$modulePaths += $AzModuleCachePath | |
} | |
$env:PSModulePath = $modulePaths -join $moduleSeperator | |
$moduleSeparator = ";" | |
} | |
else { | |
$hostedAgentModulePath = "/usr/share" | |
$moduleSeparator = ":" | |
} | |
$modulePaths = $env:PSModulePath -split $moduleSeparator | |
$modulePaths = $modulePaths.Where({ !$_.StartsWith($hostedAgentModulePath) }) | |
$AzModuleCachePath = (Get-ChildItem "$hostedAgentModulePath/az_*" -Attributes Directory) -join $moduleSeparator | |
if ($AzModuleCachePath -and $env:PSModulePath -notcontains $AzModuleCachePath) { | |
$modulePaths += $AzModuleCachePath | |
} | |
$env:PSModulePath = $modulePaths -join $moduleSeparator |
Copilot uses AI. Check for mistakes.
308c27b
to
5f0acbb
Compare
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12301 See eng/common workflow