Skip to content

Fix agent evaluation sample notebook and evaluation samples #43197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −11
Open

Fix agent evaluation sample notebook and evaluation samples #43197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fcc059
Fix agent evaluation sample notebook
Sep 30, 2025
c11e44e
Fix evaluation samples
Oct 8, 2025
18d48c1
Merge branch 'main' into selshafey/fix_sample_notebook
Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/evaluation/azure-ai-evaluation/samples/agent_evaluators/agent_evaluation.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
" project_client = AIProjectClient(\n",
" endpoint=os.environ[\"PROJECT_ENDPOINT\"],\n",
" credential=DefaultAzureCredential(),\n",
" api_version=\"latest\"\n",
" )\n",
"else:\n",
" from azure.ai.projects.models import FunctionTool, ToolSet\n",
Expand Down
8 changes: 3 additions & 5 deletions sdk/evaluation/azure-ai-evaluation/samples/evaluation_samples_evaluate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,11 +557,9 @@ def evaluation_evaluate_classes_methods(self):
response="The weather in New York is sunny.",
tool_calls={
"type": "tool_call",
"tool_call": {
"id": "call_eYtq7fMyHxDWIgeG2s26h0lJ",
"type": "function",
"function": {"name": "fetch_weather", "arguments": {"location": "New York"}},
},
"tool_call_id": "call_eYtq7fMyHxDWIgeG2s26h0lJ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a spec as reference for this change? -- The change looks good, but it should align with a spec for the users to use, e.g. it'll be great if we align it with responses API tool output

"name": "fetch_weather",
"arguments": {"location": "New York"},
},
tool_definitions={
"id": "fetch_weather",
Expand Down
8 changes: 3 additions & 5 deletions sdk/evaluation/azure-ai-evaluation/samples/evaluation_samples_evaluate_fdp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,11 +563,9 @@ def evaluation_evaluate_classes_methods(self):
response="The weather in New York is sunny.",
tool_calls={
"type": "tool_call",
"tool_call": {
"id": "call_eYtq7fMyHxDWIgeG2s26h0lJ",
"type": "function",
"function": {"name": "fetch_weather", "arguments": {"location": "New York"}},
},
"tool_call_id": "call_eYtq7fMyHxDWIgeG2s26h0lJ",
"name": "fetch_weather",
"arguments": {"location": "New York"},
},
tool_definitions={
"id": "fetch_weather",
Expand Down