Skip to content

Conversation

benbp
Copy link
Member

@benbp benbp commented Jul 24, 2024

This doesn't cover the many files still using secret sub configs with custom principals, those will be migrated separately. This changes the defaults to use file-based sub configs and service connections everywhere else. It is intended to be merged after/alongside federated auth mode becoming the default.

Relies on Azure/azure-sdk-tools#8680

CC @xiangyan99

@benbp benbp force-pushed the benbp/sub-config-sovereign branch from d2b520c to 34a8f5a Compare July 24, 2024 18:36
@benbp benbp requested a review from scbedd as a code owner July 24, 2024 18:36
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for KV

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming all these are using FederatedAuth now.

@benbp benbp merged commit 54ec2a7 into Azure:main Jul 26, 2024
@benbp benbp deleted the benbp/sub-config-sovereign branch July 26, 2024 16:49
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants