Disable distributed tracing for live metrics calls #35822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremydvoss
approved these changes
May 30, 2024
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live metrics calls are generating spans when combined with
azure.core.opentelemetry.tracing.The swaggers are generated incorrectly with
distributed-tracingdecorators, will work with Benke to get this fixed. In the meantime, we will be commenting this out in the generated code. This was generating theInprocspan.The other span of type
WCFServiceis created automatically using theDistrbutedTracingPolicycreated automatically by default when using the QuickPulseClient. We are now passing in our own list of policies that we care about, and explicitly omitting the DT policy so calls using the client won't be traced.