Skip to content

Upgrade Resource Detector version in Distro #33866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 18, 2024
Merged

Upgrade Resource Detector version in Distro #33866

merged 7 commits into from
Jan 18, 2024

Conversation

jeremydvoss
Copy link
Member

Description

Upgrade Distro to new VM Resource detector. Requires OTel 1.21/0.42b0 and exporter 1.0.0b21.

Relies on #33865

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Monitor - Distro Monitor OpenTelemetry Distro Monitor - Exporter Monitor OpenTelemetry Exporter labels Jan 16, 2024
This was referenced Jan 16, 2024
Closed
Merged
@jeremydvoss jeremydvoss force-pushed the vm-resource-detector-bug-distro branch from d683f89 to 5897a91 Compare January 16, 2024 22:45
@jeremydvoss jeremydvoss force-pushed the vm-resource-detector-bug-distro branch from 5897a91 to 3fcea79 Compare January 17, 2024 20:23
@jeremydvoss jeremydvoss marked this pull request as ready for review January 17, 2024 20:28
@jeremydvoss jeremydvoss enabled auto-merge (squash) January 17, 2024 20:28
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

lzchen
lzchen reviewed Jan 17, 2024
View reviewed changes
@jeremydvoss jeremydvoss disabled auto-merge January 17, 2024 23:32
@jeremydvoss jeremydvoss merged commit 1f60f54 into Azure:main Jan 18, 2024
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-python that referenced this pull request Feb 16, 2024
@jeremydvoss @sofiar-msft
Upgrade Resource Detector version in Distro (Azure#33866)
f69767b 
* Upgrade to new VMResourceDetector

* Increment exporter version

* Cast resource and logger_name types to fix mypy

* Type marking instead of cast

* feedback

* Add Test Resource to tests to match typing

* Type declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

Assignees
No one assigned
Labels
Monitor - Distro Monitor OpenTelemetry Distro Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremydvoss @azure-sdk @lzchen