Skip to content

Conversation

xiangyan99
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Azure.Core label Feb 2, 2022
@xiangyan99 xiangyan99 marked this pull request as ready for review February 2, 2022 23:50
@xiangyan99 xiangyan99 requested a review from lmazuel as a code owner February 2, 2022 23:50
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default to dict is an anti-pattern in Python, default to None.

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-cosmos. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-core. You can review API changes here

API changes

-             **kwargs
+             *, 
+             lro_options = ...

@xiangyan99 xiangyan99 merged commit 2bffcd0 into main Feb 3, 2022
@xiangyan99 xiangyan99 deleted the core_lro_options_arg branch February 3, 2022 01:25
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
* update to use py3 syntax

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants