Skip to content

[Feature Request] allow breaking changes for MGMT SDK #36152

@msyyc

Description

@msyyc

When I want to use detect_breaking_changes locally for MGMT SDK, I have to annotate the skip logic as following which is inconvenient:

if package_name not in RUN_BREAKING_CHANGES_PACKAGES and not any(bool(re.findall(p, package_name)) for p in RUN_BREAKING_CHANGES_PACKAGES):
_LOGGER.info(f"{package_name} opted out of breaking changes checks. "
f"See http://aka.ms/azsdk/breaking-changes-tool to opt-in.")
exit(0)

So I make PR #36051 to allow breakings detection for all MGMT SDK. However, it seems that the breaking detection tool is adopted in release pipeline:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3877372&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=090c7790-4f5a-56e9-60dd-0909d5f779fb
image

To unblock release, I have to revert it in #36104.

I notice https://github.com/Azure/azure-sdk-for-python/blob/20e6f288aa94a712d1f9a9fd6f8adef3da15b4fe/scripts/breaking_changes_checker/README.md#ignore-a-reported-breaking-change declares how to suppress breakings but it needs add it package by package and item by item which cost much effort. I hope it could also support regex like RUN_BREAKING_CHANGES_PACKAGES so that we could suppress breaking warning for all languages.
In one word, I hope to use the tool to show breakings but don't hope it reports error in release pipeline.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions