Skip to content

Conversation

@PratibhaShrivastav18
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@PratibhaShrivastav18 PratibhaShrivastav18 marked this pull request as ready for review November 7, 2025 17:05
@PratibhaShrivastav18 PratibhaShrivastav18 changed the title Add FT samples and make tests recordable Add Openai FT samples Nov 7, 2025
Copy link
Member

@nick863 nick863 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the implementation for GetFineTuningClients method.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.AI.Projects
Azure.AI.Projects.OpenAI

FileUploadPurpose.FineTune);
Console.WriteLine($"Uploaded validation file with ID: {validationFile.Id}");

// Note: In production, you should wait for files to complete processing before creating a fine-tuning job.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to move this note to the markdown file and provide the snippet of WaitForFileProcessingAsync .
```C# Snippet:AI_Projects_FineTuning_WaitForFileProcessingHelper
```

Does this code work like shown above if we will just run it? Will the file be in the FileStatus.Processed state?


## Wait for File Processing

In production, you should wait for files to complete processing before creating a fine-tuning job. See the helper methods in `Sample16_FineTuning_Supervised.md` for `WaitForFileProcessingAsync` and `WaitForFileProcessing` implementations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us add the WaitForFileProcessing for all sample to make sure that the sample is always passing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The equivalent .cs files do include the WaitForFileProcessing helper and always pass. The .md files are meant to document and I think this should convey the idea. Let's keep it this way, unless you think otherwise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to demonstrate the right practice for customer. The problem is that the code above may fail without ensuring that UploadFile has actually uploaded the file. We still have the section about File Processing, saying the WaitForFileProcessing needs to present in the production code. Lat us add WaitForFileProcessing in each sample to make sure that customer understands, what should be done. Our goal is that customer can copy our sample code and use it in production.


## Wait for File Processing

In production, you should wait for files to complete processing before creating a fine-tuning job. See the helper methods in `Sample16_FineTuning_Supervised.md` for `WaitForFileProcessingAsync` and `WaitForFileProcessing` implementations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to demonstrate the right practice for customer. The problem is that the code above may fail without ensuring that UploadFile has actually uploaded the file. We still have the section about File Processing, saying the WaitForFileProcessing needs to present in the production code. Lat us add WaitForFileProcessing in each sample to make sure that customer understands, what should be done. Our goal is that customer can copy our sample code and use it in production.

@nick863 nick863 merged commit cd9cd33 into Azure:feature/ai-foundry/agents-v2 Dec 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants