Skip to content

Conversation

@violetVo
Copy link
Contributor

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added the Monitor Monitor, Monitor Ingestion, Monitor Query label Oct 29, 2025
@violetVo violetVo marked this pull request as ready for review October 30, 2025 09:24
Copilot AI review requested due to automatic review settings October 30, 2025 09:24
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.Monitor

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Monitor Metric Alerts API from the stable 2018-03-01 version to the preview 2024-03-01-preview version. The update introduces support for PromQL-based query alert rules and makes several breaking changes to the API.

  • Updates API version from 2018-03-01 to 2024-03-01-preview
  • Adds new PromQL criteria types (PromQLCriteria, StaticPromQLCriteria, DynamicPromQLCriteria) for Prometheus-based alerting
  • Adds support for managed service identity, custom properties, action properties, and resolve configuration
  • Changes WindowSize from required to optional in MetricAlertData constructor
  • Updates all example references in test samples to use the new API version

Reviewed Changes

Copilot reviewed 5 out of 56 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
autorest.md Updates API specification reference to preview version
MetricAlertsRestOperations.cs Updates default API version constant
MetricAlertsStatusRestOperations.cs Updates default API version constant
MetricAlertData.cs Changes constructor signature to make WindowSize optional, adds new properties
MetricAlertData.Serialization.cs Updates serialization to handle WindowSize as nullable, adds new properties
MetricAlertPatch.cs Adds identity, resolve configuration, custom properties, and action properties
Various Models Adds new PromQL criteria classes and supporting models
Sample files Updates example references to preview API version, demonstrates new PromQL functionality
API surface files Reflects all public API changes including breaking changes
ApiCompatBaseline.txt Documents breaking change for WindowSize property
Customized/MetricAlertData.cs Adds overload constructor to maintain backward compatibility

@maririos maririos added the Mgmt This issue is related to a management package. label Nov 6, 2025
@ArthurMa1978 ArthurMa1978 merged commit a83f294 into main Nov 18, 2025
17 checks passed
@ArthurMa1978 ArthurMa1978 deleted the features/violet/sdk-gen-metricAlerts-2024-03-01-preview branch November 18, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package. Monitor Monitor, Monitor Ingestion, Monitor Query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants