-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Added consolidated quickstart versions for model and agent of BasicVoiceAssistant sample … #53547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
goergenj
wants to merge
19
commits into
Azure:main
Choose a base branch
from
goergenj:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5502723
Added consolidated quickstart versions of BasicVoiceAssistant sample …
goergenj d20a1ce
Update sdk/ai/Azure.AI.VoiceLive/samples/BasicVoiceAssistant/consolid…
goergenj a3adad1
Update sdk/ai/Azure.AI.VoiceLive/samples/BasicVoiceAssistant/consolid…
goergenj 5b45252
Update sdk/ai/Azure.AI.VoiceLive/samples/BasicVoiceAssistant/consolid…
goergenj 65c7b57
Update azure-sdk-for-net.csproj
goergenj 1973045
Update Program.cs
goergenj 698a4af
Delete Program.cs
goergenj c1ddc59
Updated based on review comments
goergenj 0c899b0
Updated based on review comments
goergenj dcd2242
Fixing comments from review, cleaning up unrequired files and fixing …
goergenj 997eff0
Renamed consolidated learn docs quickstart versions and moved them up…
goergenj 3be18d6
Fixed review comment.
goergenj 957bfa2
Fixed review comment.
goergenj dc41415
Removed NAudio unapproved dependency package.
goergenj 9d6f76d
Update sdk/ai/Azure.AI.VoiceLive/samples/.gitignore
goergenj 8eb4d04
Update sdk/ai/Azure.AI.VoiceLive/samples/AgentVoiceAssistantQuickstar…
goergenj a81208d
Update sdk/ai/Azure.AI.VoiceLive/samples/AgentVoiceAssistantQuickstar…
goergenj b4f98ef
Update sdk/ai/Azure.AI.VoiceLive/samples/BasicVoiceAssistantQuickstar…
goergenj a32cfcd
Update sdk/ai/Azure.AI.VoiceLive/samples/BasicVoiceAssistantQuickstar…
goergenj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Ignore settings files to avoid committing secrets | ||
| appsettings.json | ||
| appsettings.development.json | ||
| appsettings.production.json |
41 changes: 41 additions & 0 deletions
41
...e.AI.VoiceLive/samples/AgentVoiceAssistantQuickstart/AgentVoiceAssistantQuickstart.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFrameworks>net8.0</TargetFrameworks> | ||
| <Nullable>enable</Nullable> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <AssemblyName>AgentVoiceAssistantQuickstart</AssemblyName> | ||
| <IsSamplesProject>true</IsSamplesProject> | ||
| <SupportsNetStandard20>false</SupportsNetStandard20> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Azure.Identity"/> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration" VersionOverride="8.0.0"/> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" VersionOverride="8.0.0"/> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Json" VersionOverride="8.0.0"/> | ||
| <PackageReference Include="Microsoft.Extensions.Logging" VersionOverride="8.0.0"/> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Console" VersionOverride="8.0.0"/> | ||
| <PackageReference Include="System.CommandLine" VersionOverride="2.0.0-beta4.22272.1" /> | ||
| <PackageReference Include="System.Threading.Channels" VersionOverride="9.0.8"/> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\src\Azure.AI.VoiceLive.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Update="appsettings.json"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> | ||
| </ItemGroup> | ||
|
|
||
| <Target Name="OverwriteWithDevelopmentSettings" AfterTargets="Build" Condition="'$(Configuration)' == 'Debug'"> | ||
| <Copy SourceFiles="appsettings.development.json" | ||
| DestinationFiles="$(OutputPath)appsettings.json" | ||
| OverwriteReadOnlyFiles="true" | ||
| Condition="Exists('appsettings.development.json')" /> | ||
| </Target> | ||
|
|
||
| </Project> | ||
10 changes: 10 additions & 0 deletions
10
sdk/ai/Azure.AI.VoiceLive/samples/AgentVoiceAssistantQuickstart/NuGet.Config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <configuration> | ||
| <packageSources> | ||
| <clear /> | ||
| <!-- Use the Azure DevOps feed for package distribution --> | ||
| <add key="azure-sdk-for-net" value="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json" /> | ||
| </packageSources> | ||
| <disabledPackageSources> | ||
| <clear /> | ||
| </disabledPackageSources> | ||
| </configuration> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail to build outside of the repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this based on the version in the parent folder and tested the new version. Please re-check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parent folder is incorrect and will not build outside of this repository. It also snuck in an unapproved dependency via use of override which will be remediated.
Stand-alone samples must be buildable inside the repository and stand-alone, as the docs process will export them as stand-alone samples.