-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Microsoft.StorageSync : Update Api Version from 2018-07-01 to 2018-10-01 #5126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahabhijeet Do we need to bump the nuget version here given this is a new REST API version?
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a minor versioning change
src/SDKs/StorageSync/Management.StorageSync/Microsoft.Azure.Management.StorageSync.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/StorageSync/Management.StorageSync/Microsoft.Azure.Management.StorageSync.csproj
Outdated
Show resolved
Hide resolved
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Will merge once CIs pass |
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/storagesync/resource-manager/readme.md
PR: Azure/azure-rest-api-specs#4983
Related PRs : https://github.com/Azure/azure-rest-api-specs/pulls?utf8=%E2%9C%93&q=is:pr+storagesync
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.