[core-xml] Fix build failure

[HarshaNalluru]

Packages impacted by this PR

@azure/core-xml

Issues associated with this PR

#27195

==[ BLOCKED: 4 operations ]====================================================

These operations were blocked by dependencies that failed:
  @azure/event-hubs
  @azure/test-utils
  @azure-tools/test-recorder
  @azure/core-client

==[ FAILURE: 1 operation ]=====================================================

--[ FAILURE: @azure/core-xml ]-------------------------------[ 2.09 seconds ]--

Invoking: npm run clean && tsc -p . && dev-tool run bundle && api-extractor run --local && npm run build:types 

> @azure/[email protected] clean
> rimraf dist dist-* temp types *.tgz *.log

src/xml.ts(102,7): error TS7053: Element implicitly has an 'any' type because expression of type '"?xml"' can't be used to index type 'GenericObjectOrArray<unknown>'.
  Property '?xml' does not exist on type 'GenericObjectOrArray<unknown>'.
src/xml.ts(103,12): error TS7053: Element implicitly has an 'any' type because expression of type '"?xml"' can't be used to index type 'GenericObjectOrArray<unknown>'.
  Property '?xml' does not exist on type 'GenericObjectOrArray<unknown>'.
src/xml.ts(108,21): error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'GenericObjectOrArray<unknown>'.
  No index signature with a parameter of type 'string' was found on type 'GenericObjectOrArray<unknown>'.


Operations failed.

rush build (2.46 seconds)

Spotted while working on #26748

Describe the problem that is addressed by this PR

Uses type guards to narrow down the type of parsedXml

[azure-sdk]

API change check

API changes are not detected in this pull request.

[deyaaeldeen]

Looks good but this seems like a big hammer for this fix, could we just instantiate the type variable in the method call in L99 with Record<string, any>?

[jeremymeng]

something wrong with pnpm-lock.yaml so rush update is bumping dependency versions. New fast-xml-parser version is breaking NaturalIntelligence/fast-xml-parser#612

I will fix the lock file. let's wait to see if fast-xml-parser can fix it.

[HarshaNalluru]

let's wait to see if fast-xml-parser can fix it.

should I close this PR?

[jeremymeng]

should I close this PR?

you can leave it and address Deyaa's feedback in case we don't get a fix soon. Our weekly rush full update automation will fail I suppose.

[github-actions]

Hi @HarshaNalluru. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

[github-actions]

Hi @HarshaNalluru. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.