Skip to content

Conversation

@haolingdong-msft
Copy link
Member

@haolingdong-msft haolingdong-msft commented Dec 1, 2025

Description

Fix #47398

Hi @weshaggard and @raych1, I have added the eng\scripts\ci.yml to run pester unit tests referring to this comment: #47373 (comment).
May I know how could I verify the CI successfully triggers the pester unit test of updating changelogs? Thanks in advance for your guidance!

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@haolingdong-msft haolingdong-msft marked this pull request as ready for review December 1, 2025 06:57
Copilot AI review requested due to automatic review settings December 1, 2025 06:57
Copilot finished reviewing on behalf of haolingdong-msft December 1, 2025 07:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new CI configuration file to automatically run Pester unit tests for PowerShell scripts in the eng/scripts/ directory, addressing issue #47398. The configuration leverages the existing Azure SDK PowerShell testing infrastructure.

Key Changes:

  • Adds eng/scripts/ci.yml to trigger Pester unit tests on changes to eng/scripts/* (excluding typespec)
  • Configures automatic triggers for main, feature, release, and hotfix branches
  • Sets up PR validation for the same branch patterns

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but looks good otherwise. Please do create the pipeline and ensure it is passing before merging

@haolingdong-msft
Copy link
Member Author

haolingdong-msft commented Dec 2, 2025

One question but looks good otherwise. Please do create the pipeline and ensure it is passing before merging

Hi @weshaggard, thanks for the suggestion! I completely agree to create pipeline and have a validation first. But as I wrote in the PR's description, I'm afraid I'm not famliar with pipelines and CI. Could you please provide some guidance on how to create pipeline and whether to create public pipeline or internal pipeline? Do I just click 'New Pipeline' here? https://dev.azure.com/azure-sdk/internal/_build
image

I also tried to check dotnet ci.yml. But did not know how to find the corresponding pipeline created. 😢

Thanks in advance for your guidance!

@weshaggard
Copy link
Member

Sorry I missed your earlier question. You have to manually create the pipeline which you might not have permissions for. I've created a pipeline https://dev.azure.com/azure-sdk/public/_build/results?buildId=5628830&view=results. It should trigger each time you push a new commit now so let's be sure to get it passing before we merge this PR.

@weshaggard
Copy link
Member

/azp run java - eng-scripts - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@haolingdong-msft
Copy link
Member Author

/azp run java - eng-scripts - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@haolingdong-msft
Copy link
Member Author

haolingdong-msft commented Dec 3, 2025

Sorry I missed your earlier question. You have to manually create the pipeline which you might not have permissions for. I've created a pipeline https://dev.azure.com/azure-sdk/public/_build/results?buildId=5628830&view=results. It should trigger each time you push a new commit now so let's be sure to get it passing before we merge this PR.

Thanks @weshaggard for creating the pipeline! But I'm afraid below pipelines seem hanging forever, however, when I click 'view more details', it shows the pipelins successfully complete. https://dev.azure.com/azure-sdk/public/_build/results?buildId=5628830&view=results
image

image image

I also tried to rerun using the same command as you input, but seems the two hanging pipelines are not re-triggered. And it is strange to me that there are duplicate pipelines to test powershell UT(see below screenshots). Could you provide some suggestions on beging able to run below pipelines successfully? Thank you in advance!
image

@haolingdong-msft
Copy link
Member Author

/azp run Azure.azure-sdk-for-java

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@weshaggard
Copy link
Member

I renamed it from Azure.azure-sdk-for-java to java - eng-scripts - ci and that messed up the status checks. We should be able to update it from main to fix that.

@haolingdong-msft haolingdong-msft merged commit 879ea4e into main Dec 4, 2025
14 checks passed
@haolingdong-msft haolingdong-msft deleted the ci-enable-run-pester-ut branch December 4, 2025 05:27
@haolingdong-msft
Copy link
Member Author

I renamed it from Azure.azure-sdk-for-java to java - eng-scripts - ci and that messed up the status checks. We should be able to update it from main to fix that.

Thanks @weshaggard for help. The CI passed now. I just merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inner loop, enable running pester unit tests in CI to test update changelog script

4 participants