-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add eng\scripts\ci.yml to run pester unit tests #47403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new CI configuration file to automatically run Pester unit tests for PowerShell scripts in the eng/scripts/ directory, addressing issue #47398. The configuration leverages the existing Azure SDK PowerShell testing infrastructure.
Key Changes:
- Adds
eng/scripts/ci.ymlto trigger Pester unit tests on changes toeng/scripts/*(excluding typespec) - Configures automatic triggers for main, feature, release, and hotfix branches
- Sets up PR validation for the same branch patterns
weshaggard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but looks good otherwise. Please do create the pipeline and ensure it is passing before merging
Hi @weshaggard, thanks for the suggestion! I completely agree to create pipeline and have a validation first. But as I wrote in the PR's description, I'm afraid I'm not famliar with pipelines and CI. Could you please provide some guidance on how to create pipeline and whether to create public pipeline or internal pipeline? Do I just click 'New Pipeline' here? https://dev.azure.com/azure-sdk/internal/_build I also tried to check dotnet ci.yml. But did not know how to find the corresponding pipeline created. 😢 Thanks in advance for your guidance! |
|
Sorry I missed your earlier question. You have to manually create the pipeline which you might not have permissions for. I've created a pipeline https://dev.azure.com/azure-sdk/public/_build/results?buildId=5628830&view=results. It should trigger each time you push a new commit now so let's be sure to get it passing before we merge this PR. |
|
/azp run java - eng-scripts - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - eng-scripts - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks @weshaggard for creating the pipeline! But I'm afraid below pipelines seem hanging forever, however, when I click 'view more details', it shows the pipelins successfully complete. https://dev.azure.com/azure-sdk/public/_build/results?buildId=5628830&view=results
I also tried to rerun using the same command as you input, but seems the two hanging pipelines are not re-triggered. And it is strange to me that there are duplicate pipelines to test powershell UT(see below screenshots). Could you provide some suggestions on beging able to run below pipelines successfully? Thank you in advance! |
|
/azp run Azure.azure-sdk-for-java |
|
No pipelines are associated with this pull request. |
|
I renamed it from |
Thanks @weshaggard for help. The CI passed now. I just merged the PR. |





Description
Fix #47398
Hi @weshaggard and @raych1, I have added the
eng\scripts\ci.ymlto run pester unit tests referring to this comment: #47373 (comment).May I know how could I verify the CI successfully triggers the pester unit test of updating changelogs? Thanks in advance for your guidance!
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines