[Tooling] Updating script to handle output of batch processing from autorest #5081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
|
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-jsUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-javaUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-rubyUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-nodeUnable to detect any generation context from this PR. |
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
I like the hotfix but really AutoRest should be honoring JSON message format in its output. I have opened an issue against Autorest here too |
dsgouda
pushed a commit
that referenced
this pull request
Jan 24, 2019
* fixed some invalid values in dl account examples * adding resource group sample * removed . * updating script to handle output of batch processing from autorest (#5081)
TalluriAnusha
pushed a commit
to AsrOneSdk/azure-rest-api-specs
that referenced
this pull request
Feb 6, 2019
TalluriAnusha
pushed a commit
to AsrOneSdk/azure-rest-api-specs
that referenced
this pull request
Feb 6, 2019
* fixed some invalid values in dl account examples * adding resource group sample * removed . * updating script to handle output of batch processing from autorest (Azure#5081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating the script to remove the line added when processing batch tasks in AutoRest output, as we process the string.
I've also requested an update to AutoRest to honor json as the message-format switch is passed, so hopefully we can remove some of this processing in the future.