Skip to content

Conversation

@jperovic
Copy link
Member

@jperovic jperovic commented Nov 7, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@jperovic jperovic requested a review from a team as a code owner November 7, 2025 20:45
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.DBforPostgreSQL
Go sdk/resourcemanager/postgresql/armpostgresqlflexibleservers
Java com.azure.resourcemanager:azure-resourcemanager-postgresqlflexibleserver
Python azure-mgmt-postgresqlflexibleservers
Go sdk/resourcemanager/postgresql/armpostgresql

@github-actions github-actions bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview BreakingChange-Go-Sdk BreakingChange-Python-Sdk WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview labels Nov 7, 2025
@jperovic
Copy link
Member Author

jperovic commented Nov 7, 2025

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@jperovic
Copy link
Member Author

jperovic commented Nov 7, 2025

/azp run SDK Validation - Go, SDK Validation - Python, SDK Validation - .NET, SDK Validation - Java, SDK Validation - JS

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@jperovic
Copy link
Member Author

jperovic commented Nov 7, 2025

/azp run SDK Validation Status

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jperovic jperovic force-pushed the dev/jovanperovic/migrate-network-mode-spec branch 2 times, most recently from e340979 to 8b17aa2 Compare November 10, 2025 09:50
@github-actions github-actions bot added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Nov 10, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 18, 2025
@jperovic jperovic force-pushed the dev/jovanperovic/migrate-network-mode-spec branch 2 times, most recently from d50d58a to cd6320b Compare November 19, 2025 15:39
@jperovic jperovic requested a review from ravimeda November 20, 2025 11:40
@github-actions github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 20, 2025
@jperovic jperovic force-pushed the dev/jovanperovic/migrate-network-mode-spec branch from cd6320b to 718265b Compare November 20, 2025 11:45
@ravimeda ravimeda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 20, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 20, 2025
@jperovic jperovic force-pushed the dev/jovanperovic/migrate-network-mode-spec branch 7 times, most recently from b52074d to da79f2f Compare November 27, 2025 09:20
Jovan Perovic added 5 commits November 27, 2025 16:03
Updated operationId and tags

Modified API response

Added API example

Some tweaks to API

Added example for HTTP 200

Updated bad operationId in AdvancedThreatProtectionSettings

Moving MigrateNetwork to Servers operations

Changed operation description, removed MigrateNetwork.json from input

Fixed bad filename

Reverting changes to AdvancedThreatProtectionSettings.json

Reapply "Reverting changes to AdvancedThreatProtectionSettings.json"

This reverts commit fa18e53.

Added state to MigrateNetworkStatus response

Revert "Reverting changes to AdvancedThreatProtectionSettings.json"

This reverts commit ed28203.

Adding supression for BC-break ModifiedOperationId from Servers.json

Revert "Adding supression for BC-break ModifiedOperationId from Servers.json"

This reverts commit d5d07c1.

Upgraded the default tag
@jperovic jperovic force-pushed the dev/jovanperovic/migrate-network-mode-spec branch from da79f2f to 4dc47a5 Compare November 27, 2025 15:03
@jperovic jperovic enabled auto-merge (squash) November 27, 2025 20:58
Copy link
Member

@nachoalonsoportillo nachoalonsoportillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jperovic jperovic merged commit 16e0979 into Azure:main Nov 28, 2025
38 of 41 checks passed
lmazuel pushed a commit that referenced this pull request Dec 2, 2025
…#38674)

* Base files for 2026-01-01-preview API version

* Replacing occurrence of 2025-08-01 with 2026-01-01-preview

* Adding a new API spec file

Updated operationId and tags

Modified API response

Added API example

Some tweaks to API

Added example for HTTP 200

Updated bad operationId in AdvancedThreatProtectionSettings

Moving MigrateNetwork to Servers operations

Changed operation description, removed MigrateNetwork.json from input

Fixed bad filename

Reverting changes to AdvancedThreatProtectionSettings.json

Reapply "Reverting changes to AdvancedThreatProtectionSettings.json"

This reverts commit fa18e53.

Added state to MigrateNetworkStatus response

Revert "Reverting changes to AdvancedThreatProtectionSettings.json"

This reverts commit ed28203.

Adding supression for BC-break ModifiedOperationId from Servers.json

Revert "Adding supression for BC-break ModifiedOperationId from Servers.json"

This reverts commit d5d07c1.

Upgraded the default tag

* Updated API description

* Modifed 202 description. Sorted enum item in RecommendationType

---------

Co-authored-by: Jovan Perovic <[email protected]>
petarperin-mdcs added a commit that referenced this pull request Dec 8, 2025
nasc17 pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PostgreSQL PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants