Skip to content

Conversation

@aim-for-better
Copy link
Member

@aim-for-better aim-for-better commented Jan 19, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

  • Add display.description and properties to operation object to fix the correctness issue
  • Fix DeletionOperationResponse linting error
  • Add privateIPAddress property to ConnectivityEndpoints and ApplicationGetEndpoints to fix the correctness issue

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 19, 2021

Swagger Validation Report

️❌BreakingChange: 9 Errors, 0 Warnings failed [Detail]

Rule Message
1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.HDInsight/stable/2018-06-01-preview/applications.json#L223:11
1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L208:11
1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.HDInsight/stable/2018-06-01-preview/extensions.json#L166:11
1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.HDInsight/stable/2018-06-01-preview/extensions.json#L311:11
1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.HDInsight/stable/2018-06-01-preview/scriptActions.json#L76:11
1041 - AddedPropertyInResponse The new version has a new property 'privateIPAddress' in response that was not found in the old version.
New: Microsoft.HDInsight/stable/2018-06-01-preview/applications.json#L270:7
Old: Microsoft.HDInsight/stable/2018-06-01-preview/applications.json#L267:7
1041 - AddedPropertyInResponse The new version has a new property 'privateIPAddress' in response that was not found in the old version.
New: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L1218:7
Old: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L1215:7
1041 - AddedPropertyInResponse The new version has a new property 'description' in response that was not found in the old version.
New: Microsoft.HDInsight/stable/2018-06-01-preview/operations.json#L80:11
Old: Microsoft.HDInsight/stable/2018-06-01-preview/operations.json#L80:11
1041 - AddedPropertyInResponse The new version has a new property 'properties' in response that was not found in the old version.
New: Microsoft.HDInsight/stable/2018-06-01-preview/operations.json#L73:7
Old: Microsoft.HDInsight/stable/2018-06-01-preview/operations.json#L73:7
️⚠️LintDiff: 5 Warnings warning [Detail]

Rule Message
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
New: Microsoft.HDInsight/stable/2018-06-01-preview/operations.json#L99
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRegionalMdmAccount
New: Microsoft.HDInsight/stable/2018-06-01-preview/operations.json#L167
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: fillGapWithZero
New: Microsoft.HDInsight/stable/2018-06-01-preview/operations.json#L183
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isInternal
New: Microsoft.HDInsight/stable/2018-06-01-preview/operations.json#L195
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: toBeExportedForShoebox
New: Microsoft.HDInsight/stable/2018-06-01-preview/operations.json#L228
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 19, 2021

Swagger Generation Artifacts

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from c8afc74. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-5.0
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.HDInsight [View full logs]  [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from c8afc74. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️hdinsight/mgmt/2018-06-01/hdinsight [View full logs]  [Release SDK Changes]
    info	[Changelog] ## New Content
    info	[Changelog]
    info	[Changelog] - New const `Default`
    info	[Changelog] - New const `Recommend`
    info	[Changelog] - New function `BillingResponseListResult.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `ClusterIdentityUserAssignedIdentitiesValue.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New struct `Dimension`
    info	[Changelog] - New struct `ExcludedServicesConfig`
    info	[Changelog] - New struct `MetricSpecifications`
    info	[Changelog] - New struct `OperationProperties`
    info	[Changelog] - New struct `ServiceSpecification`
    info	[Changelog] - New struct `VMSizeProperty`
    info	[Changelog] - New field `EncryptDataDisks` in struct `Role`
    info	[Changelog] - New field `StorageProfile` in struct `ClusterGetProperties`
    info	[Changelog] - New field `ClusterHdpVersion` in struct `ClusterGetProperties`
    info	[Changelog] - New field `ExcludedServicesConfig` in struct `ClusterGetProperties`
    info	[Changelog] - New field `PrivateIPAddress` in struct `ConnectivityEndpoint`
    info	[Changelog] - New field `TenantID` in struct `ClusterIdentityUserAssignedIdentitiesValue`
    info	[Changelog] - New field `VMSizeProperties` in struct `BillingResponseListResult`
    info	[Changelog] - New field `VMSizesWithEncryptionAtHost` in struct `BillingResponseListResult`
    info	[Changelog] - New field `PrivateIPAddress` in struct `ApplicationGetEndpoint`
    info	[Changelog] - New field `Properties` in struct `Operation`
    info	[Changelog] - New field `Description` in struct `OperationDisplay`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 24 additive change(s).
    info	[Changelog]
  • ️✔️preview/hdinsight/mgmt/2015-03-01-preview/hdinsight [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from c8afc74. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] 2021-01-20 07:20:10 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-hdinsight;1.0.0-beta.1;1.0.0-beta.2"
    cmderr	[generate.py] 2021-01-20 07:20:10 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
    cmderr	[generate.py] 2021-01-20 07:20:10 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/hdinsight/azure-resourcemanager-hdinsight --java.namespace=com.azure.resourcemanager.hdinsight   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md
    cmderr	[generate.py] 2021-01-20 07:20:48 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-hdinsight
    cmderr	[generate.py] 2021-01-20 07:20:48 INFO [POM][Process] dealing with pom.xml
    cmderr	[generate.py] 2021-01-20 07:20:48 INFO [POM][Skip] pom already has module azure-resourcemanager-hdinsight
    cmderr	[generate.py] 2021-01-20 07:20:48 INFO [POM][Success] Write to pom.xml
    cmderr	[generate.py] 2021-01-20 07:20:48 INFO [POM][Process] dealing with root pom
    cmderr	[generate.py] 2021-01-20 07:20:48 INFO [POM][Skip] pom already has module sdk/hdinsight
    cmderr	[generate.py] 2021-01-20 07:20:48 INFO [POM][Success] Write to root pom
    cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
    cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
    cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
    cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
    cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
  • ️✔️azure-resourcemanager-hdinsight [View full logs]  [Release SDK Changes]
    cmderr	[Inst] 2021-01-20 07:23:03 DEBUG Got artifact_id: azure-resourcemanager-hdinsight
    cmderr	[Inst] 2021-01-20 07:23:03 DEBUG Got artifact: pom.xml
    cmderr	[Inst] 2021-01-20 07:23:03 DEBUG Got artifact: azure-resourcemanager-hdinsight-1.0.0-beta.2.jar
    cmderr	[Inst] 2021-01-20 07:23:03 DEBUG Match jar package: azure-resourcemanager-hdinsight-1.0.0-beta.2.jar
    cmderr	[Inst] 2021-01-20 07:23:03 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12493/azure-sdk-for-java/azure-resourcemanager-hdinsight/azure-resourcemanager-hdinsight-1.0.0-beta.2.jar\" -o azure-resourcemanager-hdinsight-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-hdinsight -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-hdinsight-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
    ```"}
️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from c8afc74. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	python3 -m venv venv
    command	pip install --upgrade setuptools wheel pip
    command	pip install pathlib jinja2 msrestazure
    command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md
  • ️✔️azure-mgmt-hdinsight [View full logs]  [Release SDK Changes]
    cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-hdinsight
    cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-hdinsight
    cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
    cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.hdinsight
    cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.hdinsight
    cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.hdinsight
    cmderr	[changelogReport] INFO:__main__:Report written to sdk/hdinsight/azure-mgmt-hdinsight/code_reports/latest/report.json
    cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-hdinsight on PyPI
    cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '0.2.1', '0.3.0', '1.0.0', '1.1.0', '1.2.0', '1.3.0', '1.4.0', '1.5.0', '1.5.1', '1.6.0', '1.7.0', '2.0.0', '2.1.0', '7.0.0b1', '7.0.0']
    cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
    cmderr	[changelogReportLatest] INFO:__main__:Installing version 2.1.0 of azure-mgmt-hdinsight in a venv
    cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
    cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.hdinsight
    cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.hdinsight
    cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.hdinsight
    cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/hdinsight/azure-mgmt-hdinsight/code_reports/2.1.0/report.json
    cmdout	[Changelog] Size of delta 12.324% size of original (original: 54253 chars, delta: 6686 chars)
    cmdout	[Changelog] **Features**
    cmdout	[Changelog]   - Model ClusterGetProperties has a new parameter excluded_services_config
    cmdout	[Changelog]   - Model ClusterGetProperties has a new parameter storage_profile
    cmdout	[Changelog]   - Model ClusterGetProperties has a new parameter cluster_hdp_version
    cmdout	[Changelog]   - Model BillingResponseListResult has a new parameter vm_sizes_with_encryption_at_host
    cmdout	[Changelog]   - Model BillingResponseListResult has a new parameter vm_size_properties
    cmdout	[Changelog]   - Model Role has a new parameter encrypt_data_disks
    cmdout	[Changelog]   - Model Operation has a new parameter properties
    cmdout	[Changelog]   - Model ClusterIdentityUserAssignedIdentitiesValue has a new parameter tenant_id
    cmdout	[Changelog]   - Model OperationDisplay has a new parameter description
    cmdout	[Changelog]   - Model ApplicationGetEndpoint has a new parameter private_ip_address
    cmdout	[Changelog]   - Model ConnectivityEndpoint has a new parameter private_ip_address
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from c8afc74. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md
  • ️✔️@azure/arm-hdinsight [View full logs]  [Release SDK Changes]
    cmderr	[npmPack] loaded rollup.config.js with warnings
    cmderr	[npmPack] (!) Unused external imports
    cmderr	[npmPack] default imported from external module 'rollup' but never used
    cmderr	[npmPack] ./esm/hDInsightManagementClient.js → ./dist/arm-hdinsight.js...
    cmderr	[npmPack] created ./dist/arm-hdinsight.js in 466ms
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from c8afc74. Schema Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	autorest --use=@autorest/[email protected] --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md
    cmdout	[Autorest] WARNING: Found duplicate definition for type Microsoft.HDInsight/clusters/extensions in scope ResourceGroup
    cmdout	[Autorest] WARNING: Found duplicate definition for type Microsoft.HDInsight/clusters/extensions in scope ResourceGroup
  • ️✔️hdinsight [View full logs]  [Release Schema Changes]
    cmderr	[resource-manager] node-pre-gyp
    cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
    cmderr	[resource-manager]  WARN [email protected] No repository field.
    cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
    cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
Rule Message
RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=188926&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
"detail":"Run.ps1 failed with exit code 1 "
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi @aim-for-better, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

TaskHow to fixPrioritySupport (Microsoft alias)
AvocadoFix-AvocadoHighruowan
Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
LintDiffFix-LintDiffhighjianyxi, ruoxuan
If you need further help, please feedback via swagger feedback."

@aim-for-better
Copy link
Member Author

Hi @JeffreyRichter Could you please help review this PR? We need your breaking change approval.
The change description is as bellow:
Add display.description and properties to operation object to fix the correctness issue
Fix DeletionOperationResponse linting error
Add privateIPAddress property to ConnectivityEndpoints and ApplicationGetEndpoints to fix the correctness issue

@openapi-workflow-bot
Copy link

Hi @aim-for-better, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

Fix DeletionOperationResponse linting error
Add privateIPAddress in ConnectivityEndpoints and
ApplicationGetEndpoints
@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 19, 2021
@aim-for-better
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@aim-for-better
Copy link
Member Author

Hi @leni-msft could you please help review this PR?

@leniatgh
Copy link
Contributor

@aim-for-better pls fix the Model Validation errors

@aim-for-better
Copy link
Member Author

@aim-for-better pls fix the Model Validation errors

Ok

@aim-for-better
Copy link
Member Author

Hi @leni-msft The model validation error has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants