[SQL] Port SqlDatabaseBackupShortTermRetentionPolicy preview cmdlets to master #8376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredmoo
suggested changes
Jan 23, 2019
Contributor
jaredmoo
left a comment
jaredmoo
left a comment
There was a problem hiding this comment.
Aren't there any tests?
Contributor
Author
@jaredmoo Yep, |
jaredmoo
previously approved these changes
Jan 23, 2019
cormacpayne
suggested changes
Jan 23, 2019
Member
cormacpayne
left a comment
cormacpayne
left a comment
There was a problem hiding this comment.
@dealaus two minor comments, otherwise LGTM
src/Sql/Sql/Database Backup/Cmdlet/AzureSqlDatabaseBackupShortTermRetentionPolicyCmdletBase.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/Database Backup/Cmdlet/AzureSqlDatabaseBackupShortTermRetentionPolicyCmdletBase.cs
Outdated
Show resolved
Hide resolved
…baseBackupShortTermRetentionPolicy
cormacpayne
previously approved these changes
Jan 25, 2019
Member
cormacpayne
left a comment
cormacpayne
left a comment
There was a problem hiding this comment.
LGTM -- this should be merged after the release branch has been merged back into master
cormacpayne
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Get-AzSqlDatabaseBackupShortTermRetentionPolicy and Set-AzSqlDatabaseBackupShortTermRetentionPolicy to master.
These cmdlets have been in Az[ureRM].Sql-preview for >6 months. Moving to stable branch.
NOTE: I am unable to port the applicable tests right now because my MSDN subscription is disabled which prevents me from re-recording tests. I will do this once it is re-enabled. I did manual testing in the interim.Original PR: #6326 (comment)
Addressing issue: https://github.com/MicrosoftDocs/azure-docs/issues/9312#issuecomment-456498276
Checklist
CONTRIBUTING.mdplatyPSmodule