[Test Controller] New test controller applied to Automation #8285

vladimir-shcherbakov · 2019-01-10T23:48:38Z

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review (Microsoft internal partners only)
- the cmdlet markdown files were generated using the platyPS module

MiYanni

LGTM

MiYanni · 2019-01-23T00:02:49Z

@vladimir-shcherbakov There are merge conflicts.

vladimir-shcherbakov · 2019-01-24T02:03:11Z

@vrdmr We are applying a new test controller - could you take a look?

vrdmr · 2019-01-28T23:06:09Z

@sourabhguha, @GaneshMSAzure, @NarayanThiru, @kjohn-msft, @safeermohammed, @AnatoliB, @jemex, @NicoletazMS and @finiteattractor: FYI - New Test Controller for Automation cmdlets

vrdmr

LGTM

vladimir-shcherbakov · 2019-01-29T18:36:05Z

signing: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/psnetsign-esrp/116/

vladimir-shcherbakov · 2019-01-29T21:18:17Z

@MiYanni Are you ready to sign off?

MiYanni · 2019-01-31T20:51:59Z

@vladimir-shcherbakov Please reassign to someone else. Thanks.

markcowl

Minor comments about the namespace name for the new class, aso, it would be nice if all the usings weher outside namespace declarations. otherwise LGTM

markcowl · 2019-01-31T20:59:40Z

src/Automation/Automation.Test/ScenarioTests/ScheduleTests.cs

 // ----------------------------------------------------------------------------------

+using Microsoft.Azure.Commands.Network.Test.ScenarioTests;
+


Please put all the usings either inside or outside the namespace

markcowl · 2019-01-31T20:59:51Z

src/Automation/Automation.Test/ScenarioTests/SourceControlTests.cs

 are recorded. See example in SourceControlTests.ps1 where $testReposInfo is defined.
 */

+using Microsoft.Azure.Commands.Network.Test.ScenarioTests;


same comment

markcowl · 2019-01-31T20:59:59Z

src/Automation/Automation.Test/ScenarioTests/UpdateManagementTests.cs

 // limitations under the License.
 // ----------------------------------------------------------------------------------

+using Microsoft.Azure.Commands.Network.Test.ScenarioTests;


same comment

markcowl · 2019-01-31T21:00:11Z

src/Automation/Automation.Test/ScenarioTests/VariableTests.cs

 // limitations under the License.
 // ----------------------------------------------------------------------------------

+using Microsoft.Azure.Commands.Network.Test.ScenarioTests;


same comment

markcowl · 2019-01-31T21:00:19Z

src/Automation/Automation.Test/ScenarioTests/WebhookTests.cs

 // limitations under the License.
 // ----------------------------------------------------------------------------------

+using Microsoft.Azure.Commands.Network.Test.ScenarioTests;


markcowl · 2019-01-31T21:02:56Z

src/Automation/Automation.Test/ScenarioTests/AccountTests.cs


-using Microsoft.Azure.Commands.Automation.Test;
-using Microsoft.Azure.ServiceManagement.Common.Models;
+using Microsoft.Azure.Commands.Network.Test.ScenarioTests;


Why is the using for the network scenario tests required?

markcowl · 2019-01-31T21:04:03Z

src/Automation/Automation.Test/ScenarioTests/AutomationTestRunner.cs

+using Microsoft.WindowsAzure.Commands.ScenarioTest;
+using Xunit.Abstractions;
+
+namespace Microsoft.Azure.Commands.Network.Test.ScenarioTests


The namespace here should be Microsoft.Azure.Commands.Automation.Test or Commands.Automation.Test

markcowl · 2019-01-31T21:04:18Z

src/Automation/Automation.Test/ScenarioTests/AutomationTests.cs

 // ----------------------------------------------------------------------------------

-using Microsoft.Azure.ServiceManagement.Common.Models;
+using Microsoft.Azure.Commands.Network.Test.ScenarioTests;


see namepspace comment above

markcowl · 2019-01-31T21:04:29Z

src/Automation/Automation.Test/ScenarioTests/CertificateTests.cs

-    using System.Threading.Tasks;
-    using Microsoft.Azure.Commands.Automation.Test;
-    using Microsoft.Azure.ServiceManagement.Common.Models;
+    using Microsoft.Azure.Commands.Network.Test.ScenarioTests;


same comment

markcowl · 2019-01-31T21:04:52Z

src/Automation/Automation.Test/ScenarioTests/ConnectionTests.cs

-    using System.Threading.Tasks;
-    using Microsoft.Azure.Commands.Automation.Test;
-    using Microsoft.Azure.ServiceManagement.Common.Models;
+    using Microsoft.Azure.Commands.Network.Test.ScenarioTests;


same comment, and for all those below

New test controller applied to Automation

128d887

azuresdkci added the needs-review label Jan 11, 2019

MiYanni previously approved these changes Jan 23, 2019

View reviewed changes

MiYanni added Merge Conflicts and removed needs-review labels Jan 23, 2019

MiYanni assigned vladimir-shcherbakov Jan 23, 2019

Merge branch 'master' into tc-core-automation

0a294b6

vladimir-shcherbakov dismissed MiYanni’s stale review via 0a294b6 January 23, 2019 21:15

vladimir-shcherbakov added needs-review and removed Merge Conflicts labels Jan 24, 2019

vladimir-shcherbakov assigned vrdmr and unassigned vladimir-shcherbakov Jan 24, 2019

vrdmr assigned sourabhguha, safeermohammed, AnatoliB, jemex, nicoletaz3 and finiteattractor and unassigned vrdmr Jan 28, 2019

vrdmr reviewed Jan 29, 2019

View reviewed changes

vladimir-shcherbakov unassigned sourabhguha, safeermohammed, AnatoliB, jemex, nicoletaz3 and finiteattractor Jan 29, 2019

vladimir-shcherbakov added Waiting for CI and removed needs-review labels Jan 29, 2019

vladimir-shcherbakov assigned MiYanni Jan 29, 2019

MiYanni removed their assignment Jan 31, 2019

markcowl requested changes Jan 31, 2019

View reviewed changes

markcowl added needs-revision and removed Waiting for CI labels Jan 31, 2019

markcowl assigned vladimir-shcherbakov Jan 31, 2019

PR comments fix

72be768

vladimir-shcherbakov assigned markcowl and unassigned vladimir-shcherbakov Feb 11, 2019

vladimir-shcherbakov added needs-review and removed needs-revision labels Feb 11, 2019

markcowl approved these changes Feb 13, 2019

View reviewed changes

markcowl merged commit b95b60b into Azure:master Feb 13, 2019

		// ----------------------------------------------------------------------------------

		using Microsoft.Azure.Commands.Network.Test.ScenarioTests;

[Test Controller] New test controller applied to Automation #8285

[Test Controller] New test controller applied to Automation #8285

Uh oh!

Conversation

vladimir-shcherbakov commented Jan 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

MiYanni left a comment

Choose a reason for hiding this comment

Uh oh!

MiYanni commented Jan 23, 2019

Uh oh!

vladimir-shcherbakov commented Jan 24, 2019

Uh oh!

vrdmr commented Jan 28, 2019

Uh oh!

vrdmr left a comment

Choose a reason for hiding this comment

Uh oh!

vladimir-shcherbakov commented Jan 29, 2019

Uh oh!

vladimir-shcherbakov commented Jan 29, 2019

Uh oh!

MiYanni commented Jan 31, 2019

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

vladimir-shcherbakov commented Jan 10, 2019 •

edited

Loading