-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Warn users of impending removal of deployment parameters from New-Azu… #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @vivsriaus, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
@ogail Looks like a compute test is failing. Can we please ask them to fix it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vivsriaus Do not add this - it will actually make the build fail, because we have to turn on treat warnings as errors. Instead, print a messag to the verbose stream when the command is executed if a user uses this parameter
|
@markcowl Done. Can you please merge this? |
|
@vivsriaus There was an issue with the post check-in build, which was just resolved. For all peninding PRs, we are running the post-checkin build to verify that there are no breaks before merging. Should merge if there are no issues. |
Warn users of impending removal of deployment parameters from New-Azu…
…reResourceGroup