Skip to content

Conversation

@xamarsinx
Copy link
Contributor

Requires new version of RemoteApp management, WindowsAzure.Management.RemoteApp.2.0.1
Will not build as package isn't available yet

Sending for early feedback as this need to make 8/12 release

@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

azurecla commented Aug 8, 2015

Hi @Amarsi, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (amarsin). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@markcowl
Copy link
Member

@azuresdkci add to whitelist

@markcowl
Copy link
Member

@Amarsi This is not early feedback, code complete for the 8/12 release was Friday. IUf your PR is not passing by Monday morning, it will not make the release.

@xamarsinx
Copy link
Contributor Author

It came in very late for us and customer needs it desperately.
I had my changed integrated into azure-sdk-for-net on Friday evening. The new package isn't available yet.
Do I need to request somewhere for new package?

@stankovski
Copy link
Member

@stankovski
Copy link
Member

@Amarsi please pull from "upstream dev" and update your fork

@stankovski
Copy link
Member

@xamarsinx
Copy link
Contributor Author

I have found a bug, need to fix that. Also the MSI build is failing because the WindowsAzure.Management.RemoteApp.2.0.1 isn't signed. Need to publish the signed package.

@markcowl
Copy link
Member

@Amarsi You need to fix the remote app library that the cmdlets are consuming so that is is signed - you will need to update azure-sdk-for-net, and republish with a new version, then update the version here

@xamarsinx
Copy link
Contributor Author

Have updated the RemoteApp package and fixe the bug as well.
The build is successful after push.

@xamarsinx
Copy link
Contributor Author

@markcowl
Copy link
Member

@markcowl
Copy link
Member

@Amarsi Hi Amar, please resubmit this PR aginst the release branch (release-0.9.7). We will take it if you can have it submitted (and passing) today

@xamarsinx
Copy link
Contributor Author

Submitted PR against release-0.9.7 branch
#741
The build is successful.

@markcowl
Copy link
Member

@Amarsi closing in favor of the merged PR in release-0.9.7 - we will merge that back to the dev branch at the end of the release.

@markcowl markcowl closed this Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants